From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: juri@linkov.net
Subject: Re: [patch, review request] better dired-isearch-filenames reset in dired-isearch-filenames-end
Date: Thu, 28 Nov 2019 11:07:21 -0500 [thread overview]
Message-ID: <jwvd0dc0yvf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2imn4w0ln.fsf@fastmail.fm> (Filipp Gunbin's message of "Thu, 28 Nov 2019 17:13:08 +0300")
> Current code calls custom-reevaluate-setting (bug#30187), and that
> results in wrong value when dired-isearch-filenames was initialized not
> with emacs customization facility, but with plain setq in .emacs. I
> think a temporary local variable is a better way to save & restore the
> global setting, WDYT? In my tests what worked well.
Using custom-reevaluate-setting seems like a bad idea here, indeed.
It's really only meant to update settings that were evaluated "too
early" (i.e. during the dump).
Stefan
next prev parent reply other threads:[~2019-11-28 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 14:13 [patch, review request] better dired-isearch-filenames reset in dired-isearch-filenames-end Filipp Gunbin
2019-11-28 16:07 ` Stefan Monnier [this message]
2019-11-28 22:00 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd0dc0yvf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.