From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: Stephen Leake <stephen_leake@stephe-leake.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Add -other-{window, frame} variants of project-prefix-map commands
Date: Wed, 08 Jul 2020 00:06:34 -0400 [thread overview]
Message-ID: <jwvd056y7vm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <877dvesx19.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 08 Jul 2020 02:52:34 +0300")
> It seems the biggest challenge that needs to be solved before making
> any changes in core Emacs is how to keep backward-compatibility with
> keybindings added by users to the existing keymap ctl-x-4-map.
`other-frame-window` doesn't make any effort to handle that, indeed.
It provides `ofw-transient-map` instead.
I believe we could live with this kind of backward incompatibility.
> Then maybe a new command bound to `C-x 4` could just introspect
> ctl-x-4-map and run its commands as is.
We could try and manually combine ctl-x-5-map and ctl-x-4-map into
`ofw-transient-map` in `ofw--set-prefix`, but I'm not sure it's worth
the hassle.
Note also that the tension between parsing `C-x 4 FOO` as "lookup FOO in
`ctl-x-4-map` (or in `ofw-transient-map`)" and "lookup FOO in the normal
way", which is why in `ofw--set-prefix` we do:
;; FIXME: Setup a transient map to reproduce the behavior of the `C-x 4/5'
;; prefix keys, but only do it in "regular" buffers. In special buffers,
;; these extra bindings may be more annoying than anything, e.g. in Gnus's
;; summary buffer `a' open a new message buffer, so we'd want `C-x
;; 5 a' to open it in a new frame, but instead of calling
;; add-change-log-entry.
(when (eq (key-binding [?a]) 'self-insert-command) ;Heuristic!
(set-transient-map ofw-transient-map)))
-- Stefan
next prev parent reply other threads:[~2020-07-08 4:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 0:54 Add -other-{window,frame} variants of project-prefix-map commands Sean Whitton
2020-07-04 5:34 ` Add -other-{window, frame} " Stephen Leake
2020-07-04 23:24 ` Sean Whitton
2020-07-06 0:58 ` Stephen Leake
2020-07-06 0:23 ` Juri Linkov
2020-07-06 3:31 ` Stefan Monnier
2020-07-06 22:57 ` Juri Linkov
2020-07-06 23:27 ` Drew Adams
2020-07-06 23:35 ` Stefan Monnier
2020-07-07 23:52 ` Juri Linkov
2020-07-08 4:06 ` Stefan Monnier [this message]
2020-07-09 0:24 ` Juri Linkov
2020-07-09 23:58 ` Juri Linkov
2020-07-05 6:13 ` bug#42210: Add -other-window " Sean Whitton
2020-07-05 14:41 ` Eli Zaretskii
2020-07-05 18:35 ` Drew Adams
2020-07-05 20:25 ` Sean Whitton
2020-07-06 0:00 ` Drew Adams
2020-07-06 0:19 ` Juri Linkov
2020-07-06 1:58 ` Sean Whitton
2020-07-06 22:59 ` Juri Linkov
2020-07-08 6:27 ` Sean Whitton
2020-07-09 0:10 ` Juri Linkov
2020-07-11 17:09 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd056y7vm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.