From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Zach Shaftel <zshaftel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Update 1 on Bytecode Offset tracking
Date: Mon, 20 Jul 2020 22:51:53 -0400 [thread overview]
Message-ID: <jwvd04p7fjd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878sfdhft3.fsf@gmail.com> (Zach Shaftel's message of "Mon, 20 Jul 2020 20:28:40 -0400")
> A hash-table seems like the most straightforward approach, which I'm
> working on now. Doing something like in the scratch/accurate-warning-pos
> branch adds a whole lot of complexity to both C and Lisp, and toggling
> byte-compilation versions of subrs feels clunky to me (though that's
> obviously just a prototype). A hash-table of conses will hopefully be
> enough, with or without the `source-map` stuff.
Preliminary measurements suggested that the hash-table way would be too slow.
But I guess it depends on the granularity.
Maybe if we only put such annotations on the "head-cons-cells", it might
be cheap enough.
> Interesting, that's not something I had thought about. I suspect flawed
> edebug specs are common enough that this can't be relied upon.
Actually, I don't think so: since Edebug rewrites all the parts marked
as `form` or `body` with significant changes, such errors are rather
unlikely. The more frequent problems will be when the Edebug spec is
missing or failed to mark the relevant parts as `form` or `body`, in
which case we'd not only lose the annotations (which costs us extra work
to go and remove the annotations). But it's a "safe" form of failure
(a kind of "graceful degradation").
Stefan
next prev parent reply other threads:[~2020-07-21 2:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 23:10 Update 1 on Bytecode Offset tracking Zach Shaftel
2020-07-16 3:55 ` Stefan Monnier
2020-07-16 22:45 ` Zach Shaftel
2020-07-17 3:44 ` Eli Zaretskii
2020-07-17 16:20 ` Stefan Monnier
2020-07-17 20:19 ` Zach Shaftel
2020-07-17 22:08 ` Stefan Monnier
2020-07-18 21:41 ` Zach Shaftel
2020-07-19 2:34 ` Stefan Monnier
2020-07-21 0:28 ` Zach Shaftel
2020-07-21 2:51 ` Stefan Monnier [this message]
2020-07-16 7:25 ` Andrea Corallo via Emacs development discussions.
2020-07-17 0:24 ` Zach Shaftel
2020-07-17 13:47 ` Rocky Bernstein
2020-07-28 19:19 ` Update 2 " Zach Shaftel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd04p7fjd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=zshaftel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.