From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped. Date: Tue, 22 Sep 2020 10:09:43 -0400 Message-ID: References: <20200922093550.GA26819@ACM> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43558@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 16:10:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKizz-0007Zt-2i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 16:10:27 +0200 Original-Received: from localhost ([::1]:38726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKizy-0002gg-58 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 10:10:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKiza-0002gG-H5 for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKiza-0004ul-7L for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKiza-0005hx-2I for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160078379221923 (code B ref -1); Tue, 22 Sep 2020 14:10:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Sep 2020 14:09:52 +0000 Original-Received: from localhost ([127.0.0.1]:60984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKizQ-0005hV-0N for submit@debbugs.gnu.org; Tue, 22 Sep 2020 10:09:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKizO-0005hO-6K for submit@debbugs.gnu.org; Tue, 22 Sep 2020 10:09:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKizN-0002eY-Om for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:09:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKizK-0004rl-Pt for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 10:09:49 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BF3974406B2; Tue, 22 Sep 2020 10:09:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5A6BE4406AC; Tue, 22 Sep 2020 10:09:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600783784; bh=2NMXrahPkvlH6JgIF46aFS7mzqiAxn8gXET7b9ZLmMA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DEqonfae/QdoANIP5XChfP6HzQ6xNQh11FMgTyleRURt92YNtKzEZTQEjgY0WW5ll ZEknb0gFK+Fp+YGPyFX7pvjtm/H9YCsMAjLBJlr4psFZEJhEx/G130Gf8Rs8fhLJPt winR9tvi1Jl4mr42+3Gc4sJdGxCpweUYQY7XSSupMvskDv4G5DyAsAk0AhGrpSsDd1 x81eZ7kj1jgmiu2zNRKYz2dv5tCLlSVy0Elgo7V7qFMmGjNvwG416n4+OXqo1dB/uM F9yWmcKTWepWObE9DxBnbGiuu1cu4Yr/YqdQk59FjnBegQIf63dixRti9hRjGIRgTU /pPFQzxoyY2bA== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 345B2120746; Tue, 22 Sep 2020 10:09:44 -0400 (EDT) In-Reply-To: <20200922093550.GA26819@ACM> (Alan Mackenzie's message of "Tue, 22 Sep 2020 09:35:50 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 10:01:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188686 Archived-At: Hi Alan, > Hello, Emacs and Stefan. > > In the following C comment: > > 1 /* > 2 \*/ > 3 /**/ > > , with point at BOL 1, do M-: (forward-comment 1). This leaves point > wrongly at EOL 2. That seems to be correct w.r.t the highlighting I see, OTOH. IOW the bug seems to affect both forward-comment and parse-partial-sexp, right? > It should end up at EOL 3, since the apparent comment > ender on L2 is actually escaped. > > The following patch fixes this. Does it fix it for `parse-partial-sexp` as well? > Are there any objections to me installing it? None from me, no. Stefan