From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2a4b0da: Make minor mode ARG work as documented Date: Sun, 01 Nov 2020 10:33:24 -0500 Message-ID: References: <20201101140048.24374.21430@vcs0.savannah.gnu.org> <20201101140050.9F050209B1@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3593"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 01 16:34:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZFMq-0000n2-F8 for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Nov 2020 16:34:04 +0100 Original-Received: from localhost ([::1]:59862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZFMp-0000dg-IU for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Nov 2020 10:34:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZFMJ-0000Bm-DI for emacs-devel@gnu.org; Sun, 01 Nov 2020 10:33:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZFMG-0008FS-TW for emacs-devel@gnu.org; Sun, 01 Nov 2020 10:33:30 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ABAAB44096C; Sun, 1 Nov 2020 10:33:27 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 78AAB440989; Sun, 1 Nov 2020 10:33:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604244806; bh=ig9tFe4Erx2X8+mbIPtXRhUwT7vAP9N+jkgXn6c372I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OSfqBRqZ1vYJw9fzj8jyJVMcZgKsa0xgUnLZa55klARKlYDfOENuaJkXLEY+R63kk kEBYjKvezXpQ9RcwytUfO92p/ninhRJfYywAGaljC4Xa13Ek4J9kUgeLExlehW4/gI kMTovWOeidAsn6WA1yhP6dn8gUJWhtdBwCe/9dDrZ6zO0yGtTCZR/jeczZgO//6TXx KvxvPAISfyV9fJHQkAS5h25be8c6k4xg5IRZlH/sMf+G79l3FzHmNygGyp+Iy5AGVF Me9hvUN3gDn0wIBhzkbbNaFVxIy4BdpteD6wvjXh04qYj+REsWH/By/3MVEHS5AH9h 36ZpfDPaUnWSA== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F352A120205; Sun, 1 Nov 2020 10:33:25 -0500 (EST) In-Reply-To: <20201101140050.9F050209B1@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 1 Nov 2020 09:00:50 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/01 08:29:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258602 Archived-At: > +If called from Lisp, toggle the mode if if ARG is `toggle'. > +Enable the mode if ARG is nil, omitted, or is a positive number. > +All other values will disable the mode. No: only non-positive numbers should be documented to disable the mode. Other values should not be kept free for future use. > + (test-mode "what") > + (should (eq test-mode nil)))) This test is wrong, IMO. Stefan