From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 2a4b0da: Make minor mode ARG work as documented
Date: Sun, 01 Nov 2020 10:33:24 -0500 [thread overview]
Message-ID: <jwvd00x2iyn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20201101140050.9F050209B1@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 1 Nov 2020 09:00:50 -0500 (EST)")
> +If called from Lisp, toggle the mode if if ARG is `toggle'.
> +Enable the mode if ARG is nil, omitted, or is a positive number.
> +All other values will disable the mode.
No: only non-positive numbers should be documented to disable the mode.
Other values should not be kept free for future use.
> + (test-mode "what")
> + (should (eq test-mode nil))))
This test is wrong, IMO.
Stefan
next parent reply other threads:[~2020-11-01 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201101140048.24374.21430@vcs0.savannah.gnu.org>
[not found] ` <20201101140050.9F050209B1@vcs0.savannah.gnu.org>
2020-11-01 15:33 ` Stefan Monnier [this message]
2020-11-02 14:48 ` master 2a4b0da: Make minor mode ARG work as documented Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd00x2iyn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.