From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: project--files-in-directory: code formatting Date: Wed, 04 Nov 2020 09:30:36 -0500 Message-ID: References: <0751c421-d860-2d79-74ee-52806d46fc13@inventati.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Manuel Uberti Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 04 15:31:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaJoo-0007KR-JD for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 15:31:22 +0100 Original-Received: from localhost ([::1]:56222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaJon-00021C-Kp for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 09:31:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaJoA-0001X8-Rh for emacs-devel@gnu.org; Wed, 04 Nov 2020 09:30:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaJo8-0000Vs-Kl for emacs-devel@gnu.org; Wed, 04 Nov 2020 09:30:42 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 94712100528; Wed, 4 Nov 2020 09:30:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35A3F10025B; Wed, 4 Nov 2020 09:30:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604500237; bh=5ZiEFZeErXYN5DDsgp5b1mumNH7PGr1dDKVNp8cXZT8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bEcpsIhaeQRUNWcw3rwM6DK6MobC0TRIcfoKDlo/6VytCpq96WE3m52G+0ryThalv AObS02qW4jlFns51j+UU8j6MWredaeXqyj6xjpK2hcDAYoeccbt7o9gvWKfQobM1f/ 9gLOWxR9Mxqzc5a7Q50/fZ8C3aFCLwCNexv+fVxJC6jeMr6Nu4rjL1KXcFTmAiCZWl 788eGx3DK5y6rUR3fhMUMi2rxYg7gIDwTZnKDblk/GVOTfwHlOX3XMoBdVnS0IacJF mvV7BnQNAbCBKMMoiOYz5W7z/uenX9F2Y7Hqjp2vfEdSpQGHWo2nhVf4nBByL+3YWm 3/Ge5CiDwLhXg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F2199120285; Wed, 4 Nov 2020 09:30:36 -0500 (EST) In-Reply-To: <0751c421-d860-2d79-74ee-52806d46fc13@inventati.org> (Manuel Uberti's message of "Wed, 4 Nov 2020 14:26:21 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 09:13:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258676 Archived-At: > Woudln't it be cleaner formatted this way? [...] > Basically, the "else" of "if files..." on a new line, with the remaining > parenthesis on the same line as this "else". > > What do you think? Yes, please! I even added a font-lock rule to highlight such cases in red, but apparently that rule doesn't catch this particular case (if you replace the empty string with a symbol, it does catch it, tho). Stefan