all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: GNU Emacs as a lightweight IDE (seeking volunteers)
Date: Mon, 08 Mar 2021 23:14:34 -0500	[thread overview]
Message-ID: <jwvczw92e33.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADm7Y4m2fTaW+rDoJqZxOn5L7feaxdLirDbJVO3p9vw+apXroQ@mail.gmail.com> (Anand Tamariya's message of "Thu, 4 Feb 2021 12:30:08 +0530")

Anand Tamariya [2021-02-04 12:30:08] wrote:
> *TLDR* I'm seeking volunteers for merging my changes to Emacs.

I'd be quite happy to see your new features merged into Emacs, indeed.
That'll take work, but I'd really like to see it happen.

> *Stage one (Testing)*Though I've been using this for over a year, I believe
> it can do with some testing by others.
> *Stage two (Minor changes)*I'll be accepting PRs for these to my github
> repo:
> *Stage three (Major changes)*This should be final merge with main. We would
> need to do it in small chunks over emails in this mailing list. However, we
> can't get to this stage before the other two stages as that might mean
> breaking the stability.

I don't understand what kind of "breaking the stability" worries on in
this regard.  Usually there aren't any serious conflicts between merging
patches into an upstream project and continuing development&refinement
of a downstream project.

IIUC you've been working on this for a while already, so I suspect you
have a good idea of which parts of your changes are "pretty stable" and
which parts aren't.

I suggest you start sending some small patches for inclusion right away.
I suggest you start small with obvious fixes, additional tests, code
clarifications, addition of helpful comments, docstring fixes, those
kind of things.

Most of us here are not very familiar with CEDET's code (I'm a bit more
familiar with it now, since I've been working on recently to convert it
to use `lexical-binding`, but its overall structure is still far from
clear to me), so it'll take time for us to understand your code enough
to review it, and I believe you're not very familiar with our habits
either, so it'll take some time for you to learn how to present your
patches in a way that we can accept them.  Those things work best when
starting with "easy stuff" and then work our way up from there.

> It's not a separate package as I believe this should be part of base emacs.
> So I developed it as such. Given that CEDET is part of Emacs, if you have
> ideas on packaging it as a separate package, I can use your help.

As you may know, I'm a big believer in separate packages, so I may end
up suggesting to make some things into separate packages, but I suspect
some parts of your changes will belong in Emacs itself anyway.

BTW, beside those small&simple patches, a good way to start might be
also to provide an overview of what the "total patch set" contains
(in terms of code more than in terms of user-level features).


        Stefan




      parent reply	other threads:[~2021-03-09  4:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  7:00 GNU Emacs as a lightweight IDE (seeking volunteers) Anand Tamariya
2021-02-05  5:53 ` Richard Stallman
2021-02-11  5:09   ` Anand Tamariya
2021-02-11 15:35     ` T.V Raman
2021-02-15  7:25       ` Anand Tamariya
2021-02-15 12:22       ` Pankaj Jangid
2021-02-12  5:42     ` Richard Stallman
2021-03-09  3:05 ` Dmitry Gutov
2021-03-09  5:28   ` Anand Tamariya
2021-03-09 14:26     ` Dmitry Gutov
2021-03-09  4:14 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczw92e33.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=atamariya@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.