all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master b21f619: * lisp: Remove yet more always-nil variables
Date: Thu, 11 Mar 2021 14:18:15 -0500	[thread overview]
Message-ID: <jwvczw5ld04.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87im5xh6vx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 11 Mar 2021 19:39:30 +0100")

> monnier@iro.umontreal.ca (Stefan Monnier) writes:
>> -	(setq cperl-hierarchy (list l1 l2 l3))
>> +	(setq cperl-hierarchy (list () () ())) ;; (list l1 l2 l3)
> These comments about the now-removed always-nil variables seem a bit
> confusing to me...  Is these any point in having these artefacts in the
> code, or are you planning to remove them in a subsequent sweep?

Since this is made as part of the conversion between dynbind and
lexbind, I'm generally worried about the risk that I removed an "unused
lexical var" which really was an "actually used dynamic var".
So, I prefer to keep the old var's code around, in case some problem
shows up that may point to a missing dynbinding of a var named FOO.

If you want to remove those, feel free, of course, but I have no plan to
remove them in the short term (nor to keep track of them so I'll make
sure I'll remove them in the longer term).


        Stefan




      reply	other threads:[~2021-03-11 19:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210311182920.3859.19072@vcs0.savannah.gnu.org>
     [not found] ` <20210311182921.DFCE520B2E@vcs0.savannah.gnu.org>
2021-03-11 18:39   ` master b21f619: * lisp: Remove yet more always-nil variables Lars Ingebrigtsen
2021-03-11 19:18     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczw5ld04.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.