From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#38024: Remove icomplete workaround Date: Sun, 31 Oct 2021 22:38:45 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14713"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mail@daniel-mendler.de, 38024@debbugs.gnu.org, joaotavora@gmail.com, kevin.legouguec@gmail.com To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 01 03:40:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhNF4-0003fV-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Nov 2021 03:40:10 +0100 Original-Received: from localhost ([::1]:43832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhNF3-0005Yq-Ex for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Oct 2021 22:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhNEw-0005V9-9A for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 22:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhNEw-0007Qe-0U for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 22:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhNEv-00083h-R8 for bug-gnu-emacs@gnu.org; Sun, 31 Oct 2021 22:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 02:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38024 X-GNU-PR-Package: emacs Original-Received: via spool by 38024-submit@debbugs.gnu.org id=B38024.163573434230907 (code B ref 38024); Mon, 01 Nov 2021 02:40:01 +0000 Original-Received: (at 38024) by debbugs.gnu.org; 1 Nov 2021 02:39:02 +0000 Original-Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhNDy-00082Q-1A for submit@debbugs.gnu.org; Sun, 31 Oct 2021 22:39:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhNDp-00081l-CS for 38024@debbugs.gnu.org; Sun, 31 Oct 2021 22:39:00 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E5D8C441D00; Sun, 31 Oct 2021 22:38:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6F5AE441D0D; Sun, 31 Oct 2021 22:38:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635734326; bh=9/eLAWq3XDu5MFmJThqNl41/9c3+JxBwCRHBiUE6jxo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D6qSYwU7d/VXjLNQNOL5Qayzkvx3lKiazkbgUEoxYqFdxTqijyn6ZnJzEoQHFXwfz HtXaPZvg9e6h0JJUgZxm0vhrcNYW+3MWxO24uJM1zkgpEnBct1aDyH/nubW+OGupOO G+6TJsZEeI99/s2QwiXuHTIQtl2T1qX4jNvit5YbJYKxtndsDfHG0qB+Ebn15lPKYV LZ4Q8gaehp6XwbDyo2FYgb2vCyF5mU/nhDmE+NDVPAgCh2WgP+A8sD41kvj95aC4Sq hn8v906CIgrJ+bzt6YQozUTtBClgp0mYbsNdTfHGZTF/m8/qVBBE02cG3h8dhN39v7 ic9xi+ks1fndg== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 19F90120330; Sun, 31 Oct 2021 22:38:46 -0400 (EDT) In-Reply-To: (Aaron Jensen's message of "Sun, 31 Oct 2021 20:49:23 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218742 Archived-At: Aaron Jensen [2021-10-31 20:49:23] wrote: > Originally added because of: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38024 > > The reason this fixed things was not captured and I can not reproduce > the bug with the fix disabled on master. > > This workaround has been copied to other libraries without clear > understanding of why it existed in the first place and it caused a > problem: https://github.com/minad/vertico/issues/115#issuecomment-947330581 > > Would it be possible to remove it? I'm ccing the original reporter and > fixer in case they are able to shed more light on this or test without > the fix to see if they can reproduce it. > > I've attached a patch if we are good to remove it. Thanks, I just pushed your patch to `master`. We'll see if the problem comes back, and if so, we'll have to try and fix it better. Stefan