From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f8bb6cca33: Return the same file from locate-file in nativecomp and non Date: Sun, 13 Mar 2022 20:20:38 -0400 Message-ID: References: <164712074096.14747.18124931770043811100@vcs2.savannah.gnu.org> <20220312213221.451B3C01684@vcs2.savannah.gnu.org> <87fsnmyh4q.fsf@gnus.org> <87y21eviwn.fsf@gnus.org> <831qz6mlw0.fsf@gnu.org> <87bkyauecx.fsf@gnus.org> <83mthtlqo7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 14 01:22:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTYTN-0002K9-RV for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 01:22:06 +0100 Original-Received: from localhost ([::1]:38368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTYTM-0000fp-69 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Mar 2022 20:22:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTYS9-000807-JC for emacs-devel@gnu.org; Sun, 13 Mar 2022 20:20:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTYS5-0002fi-Jo; Sun, 13 Mar 2022 20:20:47 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EA70444181C; Sun, 13 Mar 2022 20:20:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 82ED2441835; Sun, 13 Mar 2022 20:20:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1647217241; bh=Gxw9hrPJ5Mqy1xcDmSYZaZs4lV09jJVlE4uS7b8ydIM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WbY4MeLpV7fc51J7YVCmeDdjfnhC4PXM4rq4enBwR3r+ihFt8/ZuNPomDH/CrVon7 g/X2MP14hqK1DFSMWS/Eo2ZgbTW2WeRhVQaw1UnkrIhr6M3Jm5EfuQfsqUdncHf+ZK EBOLOVeT6ivo6szROlngaDrPV2aMw3BgisMoH/QeCo60yT7j0dT2Y0goeGc/I5YOaX 6Sdu7w2VjJtz2fbOXxSzR0GY6rMY0jTGIxsDIt9TdPFeP+c2KBDRvqB1TcHkGDnkIa HUHBZAY030NnWRa4D7mHX/tOsc0MRP5eEXcc7BIx/EgGM3JfZJpd64IOWd6W2qDdk9 JAu2YQlaVXo5w== Original-Received: from ceviche (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4D9971201BB; Sun, 13 Mar 2022 20:20:41 -0400 (EDT) In-Reply-To: <83mthtlqo7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Mar 2022 19:15:36 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287097 Archived-At: >> AFAIK it reverts the behavior of `locate-file-internal` to that of >> Emacs-27 > Emacs 27 behavior cannot guide us here, because the *.eln files and > the aspects they bring into the issue are new. `locate-file` is a function looks for files with a given set of extensions through path. That's it. Nothing specific to ELisp files. E.g. it's used in `executable-find`. The existence of `.eln` should have no bearing on this. It can affect the ELisp-specific code (such as `load` or `find-library`), which may indeed use `locate-file` internally, but it should not affect `locate-file` itself. >> and I think the change in Emacs-28 is just a bug (an oversight, I >> suspect) > How can you think that when this "bug" endured more than a year of > testing since the nativecomp branch was merged, including the pretest > until now? That's just what my understanding of the code tells me. >> so I'd even suggest we install my patch in `emacs-28`. > Do we want to release Emacs 28 any time soon, or do we want to > continue dragging our feet by making destabilizing changes in it? Notice that I did not install it on `emacs-28` nor asked to do that. I only mention it as a way to say that I consider it fixes a regression in Emacs-28, rather than being a "backward-incompatible change". Stefan