all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org,  emacs-devel@gnu.org
Subject: Re: master f8bb6cca33: Return the same file from locate-file in nativecomp and non
Date: Sun, 13 Mar 2022 20:20:38 -0400	[thread overview]
Message-ID: <jwvczipgzqt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83mthtlqo7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Mar 2022 19:15:36 +0200")

>> AFAIK it reverts the behavior of `locate-file-internal` to that of
>> Emacs-27
> Emacs 27 behavior cannot guide us here, because the *.eln files and
> the aspects they bring into the issue are new.

`locate-file` is a function looks for files with a given set of
extensions through path.  That's it.  Nothing specific to ELisp files.
E.g. it's used in `executable-find`.

The existence of `.eln` should have no bearing on this.

It can affect the ELisp-specific code (such as `load` or
`find-library`), which may indeed use `locate-file` internally, but it
should not affect `locate-file` itself.

>> and I think the change in Emacs-28 is just a bug (an oversight, I
>> suspect)
> How can you think that when this "bug" endured more than a year of
> testing since the nativecomp branch was merged, including the pretest
> until now?

That's just what my understanding of the code tells me.

>> so I'd even suggest we install my patch in `emacs-28`.
> Do we want to release Emacs 28 any time soon, or do we want to
> continue dragging our feet by making destabilizing changes in it?

Notice that I did not install it on `emacs-28` nor asked to do that.
I only mention it as a way to say that I consider it fixes a regression
in Emacs-28, rather than being a "backward-incompatible change".


        Stefan




  reply	other threads:[~2022-03-14  0:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164712074096.14747.18124931770043811100@vcs2.savannah.gnu.org>
     [not found] ` <20220312213221.451B3C01684@vcs2.savannah.gnu.org>
2022-03-12 21:47   ` master f8bb6cca33: Return the same file from locate-file in nativecomp and non Stefan Monnier
2022-03-12 21:51     ` Lars Ingebrigtsen
2022-03-12 23:23       ` Stefan Monnier
2022-03-12 23:40         ` Lars Ingebrigtsen
2022-03-13  4:51           ` Stefan Monnier
2022-03-13  6:01             ` Eli Zaretskii
2022-03-13 14:16               ` Lars Ingebrigtsen
2022-03-13 14:26                 ` Stefan Monnier
2022-03-13 14:40                   ` Lars Ingebrigtsen
2022-03-13 17:15                   ` Eli Zaretskii
2022-03-14  0:20                     ` Stefan Monnier [this message]
2022-03-14 14:29                       ` Eli Zaretskii
2022-03-14 16:57                         ` Stefan Monnier
2022-03-14 17:22                           ` Eli Zaretskii
2022-03-14 18:09                             ` Stefan Monnier
2022-03-14 22:29                               ` Corwin Brust
2022-03-15 13:11                                 ` Stefan Monnier
2022-03-13 16:59                 ` Eli Zaretskii
2022-03-13 22:16                   ` Lars Ingebrigtsen
2022-03-14  3:26                     ` Eli Zaretskii
2022-03-14  2:57                   ` Stefan Monnier
2022-03-14  3:38                     ` Eli Zaretskii
2022-03-14  4:04                       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvczipgzqt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.