From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Date: Fri, 29 Apr 2022 09:00:38 -0400 Message-ID: References: <165123369667.6415.4605821518748112960@vcs2.savannah.gnu.org> <20220429120137.0F053C06322@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 15:02:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkQGg-0001dw-V4 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 15:02:43 +0200 Original-Received: from localhost ([::1]:55896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkQGf-0005Bo-P1 for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 09:02:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQEu-0004L5-4o for emacs-devel@gnu.org; Fri, 29 Apr 2022 09:00:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQEn-0008As-6r for emacs-devel@gnu.org; Fri, 29 Apr 2022 09:00:50 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E5C99442498; Fri, 29 Apr 2022 09:00:43 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A34D7441582; Fri, 29 Apr 2022 09:00:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651237242; bh=N+cs633lYpXrY8f/kZ08vN00DsE7t5FGusfNeDVHqWM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UR39wAOLWkM9sSEGS8v+bwZF4gFv2RK2FZR26NwdzPc52cJ1yAWThEZDR+n9qRcg7 mUTB715nMlMamDgF4Hy532W6G9UEYjoJhi2Q9F2XzNOmMu9Plc47GJt32XEyFXjkqA WocYpKUQCrWarPPXRETqPDJanSHITTIWH8vKy8gdWPkh4GFS4kHDeVhVgdFgzfhbld b+r3qun5XjhCjMPaA+sgg4stQZLnubgb5DPsB27rMBXP+DTcTSZKAfWHELzm2ntB/Y sJwg7ZqgLfN3gYu3LCCdQhOh8JGczA4kx6RtRN26ON5MiN0PsnKrdKnxemOM6xGMVg SVOQHsouENbdg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 65342120297; Fri, 29 Apr 2022 09:00:42 -0400 (EDT) In-Reply-To: <20220429120137.0F053C06322@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 29 Apr 2022 08:01:36 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288985 Archived-At: > @@ -965,7 +965,9 @@ beginning of the line." > > (defvar xref--button-map > (let ((map (make-sparse-keymap))) > - (define-key map [mouse-1] #'xref-goto-xref) > + (when mouse-1-click-follows-link > + (define-key map [mouse-1] #'xref-goto-xref)) > + (define-key map [follow-link] 'mouse-face) > (define-key map [mouse-2] #'xref-select-and-show-xref) > map)) Hmm... this won't adjust if `mouse-1-click-follows-link` is changed later on. Why do we need this `mouse-1` binding? Stefan