From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#23264: 25.0.90; `C-h f' (`describe-function'): "This function has a compiler macro" Date: Fri, 13 May 2022 10:20:17 -0400 Message-ID: References: <877d6pvb7b.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31695"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 23264@debbugs.gnu.org, Eli Zaretskii , Drew Adams To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 13 16:21:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npWAm-000835-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 16:21:41 +0200 Original-Received: from localhost ([::1]:52426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npWAl-0002Yw-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 10:21:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npWAA-0001yr-Vo for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 10:21:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npWAA-0002iF-J6 for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npWAA-0006nT-FU for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2022 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23264 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 23264-submit@debbugs.gnu.org id=B23264.165245163826066 (code B ref 23264); Fri, 13 May 2022 14:21:02 +0000 Original-Received: (at 23264) by debbugs.gnu.org; 13 May 2022 14:20:38 +0000 Original-Received: from localhost ([127.0.0.1]:44472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npW9l-0006mM-R3 for submit@debbugs.gnu.org; Fri, 13 May 2022 10:20:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npW9l-0006m8-2P for 23264@debbugs.gnu.org; Fri, 13 May 2022 10:20:37 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 75F2110025F; Fri, 13 May 2022 10:20:31 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E619910002A; Fri, 13 May 2022 10:20:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652451629; bh=JXBuUs9qCy+88qQAgOJJ2MdLsvC13p5d348w1yqCUrE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZCNoKJhloyqLmZQF3v3sqfGjWVuZRYIov3axamNx3sfj6O1VlNpNM19eseCCZbwzD UEfmJ7FqTGsYk7cXyDgY8CmRQbPpQew7EgelUidrfz0HQV8ELR5CT1KSu6Scbn3UFJ ihR1pLpQx6Zejt4mJtAxYF3x3SZ7oo82uQZlZT2eX4ObvO3iAuNXQuAsHGClWSaEIS IpPAMAkPCmfQFT/4Ai4LcqaAD8vf/bOum8X5cg0QrBVlMtQKgzuMDukL2ZCF91KvhG ovsX3o4/XNL217mm/oyGxNiB4ipGzoktz60OmQIgqZsaxm252MHsj1+GMBZ/Of+Z80 0R1R1+EVArHjQ== Original-Received: from alfajor (modemcable240.145-162-184.mc.videotron.ca [184.162.145.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BE25C120108; Fri, 13 May 2022 10:20:29 -0400 (EDT) In-Reply-To: <877d6pvb7b.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 13 May 2022 15:00:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232156 Archived-At: >> This function has a compiler macro. [...] > It doesn't seem very useful to me either, no -- it doesn't really convey > much of interest to the user. Eli, Stefan -- what do you think? Should > we just remove it? I can see to benefits: 1- If it includes a link to the compiler macro. Admittedly, compiler macros are supposed to be placed directly inside the `declare` of the function, so you can get there via the usual link to the function's definition, which makes this link's usefulness rather marginal. (except in theory for those rare exceptions where the compiler macro is not provided via `declare`, but to be honest, I can't think of any and `grep` couldn't find any either). 2- It warns that advice and (more generally) redefinitions of this function may not be obeys at all call sites. Point 1 is quite weak. Point 2 is a bit more interesting but then we should say so more explicitly and (more importantly) we should also say so for those functions which have the same property but for other reasons (e.g. they have their own byte-code, or they have a `byte-compile` or `byte-optimizer` property). IOW, I agree but maybe it would be a good idea to replace it with a better message that covers this and similar cases warning about applicability of `advice`. Stefan