* bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun
@ 2020-05-06 3:05 Michael Heerdegen
2022-06-06 13:33 ` Lars Ingebrigtsen
2022-06-07 14:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 3+ messages in thread
From: Michael Heerdegen @ 2020-05-06 3:05 UTC (permalink / raw)
To: 41104
Hello,
in *scratch* eval this:
#+begin_src emacs-lisp
(require 'find-func)
;; we don't require 'dired so it is an autoload fun. Then:
(advice-add 'dired
:override
(defun my-dired (&rest args) t))
;; And
(find-function-library 'dired)
;; infloops.
#+end_src
The problem seems be that `find-function-advised-original' unexpectedly
returns the original symbol because `advice--cd*r' returns nil in this
case.
TIA,
Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun 2020-05-06 3:05 bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun Michael Heerdegen @ 2022-06-06 13:33 ` Lars Ingebrigtsen 2022-06-07 14:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors 1 sibling, 0 replies; 3+ messages in thread From: Lars Ingebrigtsen @ 2022-06-06 13:33 UTC (permalink / raw) To: Michael Heerdegen; +Cc: 41104, Stefan Monnier Michael Heerdegen <michael_heerdegen@web.de> writes: > #+begin_src emacs-lisp > (require 'find-func) > > ;; we don't require 'dired so it is an autoload fun. Then: > > (advice-add 'dired > :override > (defun my-dired (&rest args) t)) > > ;; And > > (find-function-library 'dired) > > ;; infloops. > #+end_src > > The problem seems be that `find-function-advised-original' unexpectedly > returns the original symbol because `advice--cd*r' returns nil in this > case. This issue is still present on the trunk. Perhaps Stefan has some comments; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun 2020-05-06 3:05 bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun Michael Heerdegen 2022-06-06 13:33 ` Lars Ingebrigtsen @ 2022-06-07 14:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors 1 sibling, 0 replies; 3+ messages in thread From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-06-07 14:31 UTC (permalink / raw) To: Michael Heerdegen; +Cc: 41104-done > The problem seems be that `find-function-advised-original' unexpectedly > returns the original symbol because `advice--cd*r' returns nil in this > case. I believe the problem is now fixed in `master`. Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-07 14:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-06 3:05 bug#41104: 28.0.50; nadvice: `find-function-library' infloops for adviced autoload fun Michael Heerdegen 2022-06-06 13:33 ` Lars Ingebrigtsen 2022-06-07 14:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.