From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>, emacs-devel@gnu.org
Subject: Re: master 38697a07c0 1/2: Add :safe property to ffap-machine-p-* variables
Date: Fri, 08 Jul 2022 09:03:25 -0400 [thread overview]
Message-ID: <jwvczefdakf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <835yk74vqq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Jul 2022 15:47:09 +0300")
> This uses an internal function as the value of a property of a user
> option, which I think is not a good idea.
Why is that a problem? Internal names means users shouldn't rely on the
fact that this function exists and will keep existing under that name or
that its behavior will be preserved, but here the users aren't expected
to call this function under this internal name, they're just expected to
call the function that happens to be stored in the
`safe-local-variable`, regardless of its name and even if
it's anonymous.
Stefan
next prev parent reply other threads:[~2022-07-08 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 12:47 master 38697a07c0 1/2: Add :safe property to ffap-machine-p-* variables Eli Zaretskii
2022-07-08 13:03 ` Stefan Monnier [this message]
2022-07-08 13:16 ` Eli Zaretskii
2022-07-08 19:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvczefdakf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.