From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] em-cmpl: fix completion of command paths Date: Fri, 27 Jan 2023 19:12:11 -0500 Message-ID: References: <20230107121943.44658-1-nicolas@n16f.net> <83ilgufsdb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9762"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: nicolas@n16f.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 28 01:12:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLYpj-0002If-3V for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Jan 2023 01:12:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLYpP-000625-Sy; Fri, 27 Jan 2023 19:12:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLYpO-00061q-Fb for emacs-devel@gnu.org; Fri, 27 Jan 2023 19:12:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLYpM-00031l-Uv; Fri, 27 Jan 2023 19:12:18 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6920480DCA; Fri, 27 Jan 2023 19:12:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CA81080261; Fri, 27 Jan 2023 19:12:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1674864733; bh=AWQPpECYzwq4o6pGzquB6NEZDccCDfoNGcDLzhsdAcE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NeeUdnCvM5XadG6DDOajTjN8/9xZh4NTgnNVrRawR+4/mJk+bpFhSA+YqGzBSaf5v 1wXdFBRlL7X3S4Dq3EP87emtDCbuQhj5D90F2/BH82vCl8emaIfofbBW5xyBag+MVi U/TFILA+fVq+zGZP5BfirOZEbBNaW5kLUU9SoAR+JQ+/uDitEeJpvrtsWlNmC7h/8b 78zKEUvmkFUoXWaHoUDIKYpLeLA+Nw8A0qAa9hcPxd2lSirSXU6NB5QrrFxm0LWpIa 4rDiBLYraMCaB2QRP7vbZkLzAsuGETleuTGbgUwA0EGMijexBuGXydtdSGULWvvkWC ucSABFjAeKMbw== Original-Received: from pastel (unknown [45.72.216.69]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7EC99120AD0; Fri, 27 Jan 2023 19:12:13 -0500 (EST) In-Reply-To: <83ilgufsdb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Jan 2023 19:15:12 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302696 Archived-At: >> Eli, what do you think? > Yes, this is okay for emacs-29. Thanks, I'll push it soon. >> > + ;; Do not use `completion-table-dynamic' when completing a command path >> > + ;; (absolute or relative): doing so assumes that the subpath in the input >> > + ;; string is always a command, and appends a space character, which is >> > + ;; incorrect (i.e. "/usr/bi" should yield "/usr/bin/" after completion, >> > + ;; not "/usr/bin/ "). > > Please use "file name", not "path", when referring to file or > directory names. If you need to make it clear you are talking about > absolute file name, use "absolute file name" or "file name with > leading directories". GNU coding standards frown on using "path" for > anything but PATH-style lists of directories. (Yes, I know that most > of this text came from a comment in the original code.) Thanks for catching this. Stefan