From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded.
Date: Sat, 09 Dec 2023 15:09:35 -0500 [thread overview]
Message-ID: <jwvcyvfm9p0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <c88949a7-8728-4688-afa0-7a52bce61b85@vodafonemail.de> (Jens Schmidt's message of "Thu, 7 Dec 2023 23:25:44 +0100")
> Uh. I'm still struggling to understand all bits, but here are already
> some comments.
>
> - The docstring of `ls-lisp--insert-directory' still makes references
> to its previous advice nature, this probably should be ironed out.
I haven't really attacked the task of updating the docs yet (neither
docstrings nor manual).
> - The docstring of `insert-directory-program' does not very explicitly
> mention that its value could be nil. (Nothing introduced by your
> patch, just noticed it.)
>
> - And the custom spec of `insert-directory-program' isn't prepared for
> nil as well, but that is probably OK since it should be used for a
> generated default value only?
While I did change the code so that setting `insert-directory-program`
to nil forces the use of ls-lisp, I did it in a minimalist way so far.
I'm not sure if we want to encourage such a setting. In a sense, it
"comes for free" and it's nice to make the code robust against such
a setting.
> - AFAICT you call `files--insert-directory-program' as a predicate
> only. Probably we should rename it to `...-p' or
> `files--use-insert-directory-program'?
Yeah, it wasn't intended that way but that's indeed how things turned
out.
> - Not sure whether that makes a difference, but: Without your patch the
> advice was conditional on whether ls-lisp was loaded, now the usage of
> `ls-lisp--insert-directory' is conditional on whether
> `ls-lisp-use-insert-directory-program' is bound. What if a user has
> a .emacs with a customization or `setq' of `ls-l-u-i-d-p' to nil, which
> she uses both on Windows and Unix?
Indeed, this is a change in behavior.
Note that those users already encountered this behavior in the past when
their non-Windows system loaded `ls-lisp` at run time, e.g. because of the
use of Tramp or via `help-enable-autoload`, or ...
> - Your fix in `file-expand-wildcards'
>
> (if (equal "" nondir)
> (push (or dir nondir) contents)
>
>
> is hard to digest at 11PM, so a comment won't hurt here, I guess.
Good point, thanks.
> Plus it seems to violate the order promise done in the docstring of
> the function ("... sorted in the `string<' order").
Oh, indeed I completely missed that, thank you.
> - Now the logic gets harder and harder, so I may be wrong here. The
> docstring of `dired-insert-directory' seems to handle FILE-LIST
> exclusive to WILDCARD, as if WILDCARDS do not get expanded if
> FILE-LIST is non-nil:
>
> If FILE-LIST is non-nil, list only those files.
> Otherwise, if WILDCARD is non-nil, expand wildcards;
>
> but your patch changes that, no?
Hmm... IIUC the current code treats a "*" in the directory part as
a wildcard regardless of FILE-LIST and WILDCARD, and my patch tries to
fix that so as to better obey the docstring which says that "*" should
only be treated as wildcards if WILDCARD is non-nil and FILE-LIST
is nil.
Hopefully this will get more clear once I clean up the patch and cut it
into meaningful commits.
Stefan
next prev parent reply other threads:[~2023-12-09 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org>
[not found] ` <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org>
2023-12-05 23:20 ` master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded Stefan Monnier
2023-12-06 1:18 ` Po Lu
2023-12-06 12:14 ` Eli Zaretskii
2023-12-06 16:12 ` Stefan Monnier
2023-12-06 17:07 ` Eli Zaretskii
2023-12-06 21:32 ` Stefan Monnier
2023-12-07 6:19 ` Eli Zaretskii
2023-12-06 20:50 ` Jens Schmidt
2023-12-07 20:06 ` Stefan Monnier
2023-12-07 22:25 ` Jens Schmidt
2023-12-09 20:09 ` Stefan Monnier [this message]
2023-12-09 23:26 ` Stefan Monnier
2023-12-10 5:10 ` Stefan Monnier
2023-12-12 21:22 ` Jens Schmidt
2023-12-21 14:40 ` Stefan Monnier
2023-12-07 2:49 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvcyvfm9p0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.