From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Scheme-mode: Add support for regular expression literal Date: Mon, 01 Apr 2024 01:31:20 -0400 Message-ID: References: <87msqpfz68.fsf@niceume.com> <864jcoduaz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "Toshi Umehara" , emacs-devel@gnu.org, jcubic@onet.pl To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 01 07:32:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrAHO-0003v5-IE for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Apr 2024 07:32:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrAGj-0006hm-Bz; Mon, 01 Apr 2024 01:31:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrAGb-0006hP-1r for emacs-devel@gnu.org; Mon, 01 Apr 2024 01:31:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrAGZ-0007P1-Ls; Mon, 01 Apr 2024 01:31:32 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2D99280AF8; Mon, 1 Apr 2024 01:31:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711949481; bh=mTC3QdkCz+MD5U9yrecrxZAgzxz7LQPzfQgXSLwyevM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QW32nb11o8Q7EI6IYXqiYM1PTQlEHYmKkPYqWr5+9ZUm5X0QL7EwZb0Au8239M/WB JZNFj0pC2xbtInzZxQodZIKn2WZgul0TJfXWkRsUni0nJZ9iAAA+imVWFPCvuxw+Bv 1SqCsRRE1dfoTUb605craLEll1MOODQ8v5R5HnjF2Ex3LTpQINrSopaQj5kzYVnRVk pARQxeOr6BCkofEnTQeGhlso2K6yX9ANRJ+6TcRwOUEa1hGGlbaPFruAmjop02Rlej cpw/8yo4BVpCDp4Toj5DVg+PPLEEvioxHNieP7T2LTVmrn9F7GLFHfm//qQR+fYy70 F8UsJNidMwSPg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 23D9C805DE; Mon, 1 Apr 2024 01:31:21 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E6CCC120804; Mon, 1 Apr 2024 01:31:20 -0400 (EDT) In-Reply-To: <864jcoduaz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Mar 2024 10:59:16 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317439 Archived-At: > Stefan, any further comments? Or should I install this? I was waiting for the copyright paperwork to come through. > My only comment is that removing the unused argument from > scheme-syntax-propertize-sexp-comment constitutes a change in a public > API, so maybe we should not do that. While the name doesn't include a "--", it's really an internal function, so I think it's OK. Stefan