From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Interactive specs of C functions. Date: Sun, 09 Sep 2007 17:19:29 -0400 Message-ID: References: <87sl5qr093.fsf@cadilhac.name> <87ps0tttkt.fsf@cadilhac.name> <87fy1nr2ht.fsf@cadilhac.name> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1189374733 14849 80.91.229.12 (9 Sep 2007 21:52:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2007 21:52:13 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 10 07:51:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IUbgH-0007TV-Jy for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2007 07:19:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUUBu-0003kf-Jj for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2007 17:19:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUUBr-0003iq-5s for emacs-devel@gnu.org; Sun, 09 Sep 2007 17:19:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUUBp-0003hX-Ra for emacs-devel@gnu.org; Sun, 09 Sep 2007 17:19:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUUBp-0003hK-KD for emacs-devel@gnu.org; Sun, 09 Sep 2007 17:19:33 -0400 Original-Received: from tomts25.bellnexxia.net ([209.226.175.188] helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUUBm-0006Il-HB; Sun, 09 Sep 2007 17:19:30 -0400 Original-Received: from pastel.home ([70.55.141.227]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070909211929.RJQN19497.tomts25-srv.bellnexxia.net@pastel.home>; Sun, 9 Sep 2007 17:19:29 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6F9268073; Sun, 9 Sep 2007 17:19:29 -0400 (EDT) In-Reply-To: <87fy1nr2ht.fsf@cadilhac.name> (=?iso-8859-1?Q?=22Micha=EBl?= Cadilhac"'s message of "Sun\, 09 Sep 2007 22\:46\:22 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78353 Archived-At: > *************** > *** 770,777 **** > if (SUBRP (fun)) > { > ! if (XSUBR (fun)->prompt) > ! return list2 (Qinteractive, build_string (XSUBR (fun)->prompt)); > } > else if (COMPILEDP (fun)) > { > --- 770,777 ---- > if (SUBRP (fun)) > { > ! if (XSUBR (fun)->intspec) > ! return list2 (Qinteractive, build_string (XSUBR (fun)->intspec)); > } > else if (COMPILEDP (fun)) > { This doesn't look right. It should do the Fread_from_string thingy as well. > + (defun char-to-who (char) > + "Convert CHAR to a who-mask from a symbolic mode notation. > + CHAR is in [ugoa] and represents the users on which rights are applied." [...] > + (defun char-to-right (char &optional from) > + "Convert CHAR to a right-mask from a symbolic mode notation. > + CHAR is in [rwxXstugo] and represents a right. > + If CHAR is in [Xugo], the value is extracted from FROM (or 0 if nil)." [...] > + (defun right-string-to-number (rights who-mask &optional from) > + "Convert a right string to a right-mask from a symbolic modes notation. > + RIGHTS is the right string, it should match \"([+=-][rwxXstugo]+)+\". > + WHO-MASK is the mask number of the users on which the rights are to be applied. > + FROM (or 0 if nil) is the orginal modes of the file to be chmod'ed." These names are too generic compared to the job they do. I'd add a "file-modes" prefix or somesuch. Stefan