From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: toggling a minor mode should not tell Customize that the value has been set
Date: Sun, 06 Jan 2008 16:20:06 -0500 [thread overview]
Message-ID: <jwvbq7ysm0s.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BNELLINCGFJLDJIKDGACOEHECGAA.drew.adams@oracle.com> (Drew Adams's message of "Sun, 6 Jan 2008 12:47:23 -0800")
> I haven't seen any explanation. You've simply said, as support, that
> toggling the variable enables/disables the mode for the session.
OK, let's take a step back:
There are currently only two options: either toggling the mode
interactively causes the var to be "changed outside Customize" or it
marks it as "Customized".
The current code chooses the second and you advocate the first.
The problem with the first is that it's a catch-all case: it just says
"this has been changed somehow and we have no clue whatsoever what it
means, how it was done, whether it'll occur again in the future, and hence
Customize doesn't know what effect will result from changing and/or
saving this variable. For all Customize knows, the value might already
have changed between the time Customize read it to display it and the
time the user gets to see the displayed value".
In contrast, when the user interactively does M-x foo-mode RET, we know
that this has been done in a way that Customize can easily understand
and which does not affect its ability o make further changes and/or save
the variable. Calling it customize-mark-as-set is a way to better
interact with Customize.
For that reason, the first option is *wrong*: it loses
valuable information about how the minor mode was changed.
In my mind "customize-customized" returns the list of defcustom
variables that were changed in a principled way. Period.
If you want to distinguish more finely between "principled" and "via
Custom", go ahead, but I doubt the benefits are worth the trouble.
Stefan
next prev parent reply other threads:[~2008-01-06 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 17:48 toggling a minor mode should not tell Customize that the value has been set Drew Adams
2008-01-06 2:14 ` Stefan Monnier
2008-01-06 8:01 ` Drew Adams
2008-01-06 16:16 ` Stefan Monnier
2008-01-06 20:47 ` Drew Adams
2008-01-06 21:20 ` Stefan Monnier [this message]
2008-01-06 23:00 ` Drew Adams
2008-01-07 1:32 ` Stefan Monnier
2008-01-06 22:41 ` martin rudalics
2008-01-06 23:41 ` Drew Adams
2008-01-07 1:26 ` Stefan Monnier
2008-01-07 7:34 ` martin rudalics
2008-01-07 11:31 ` Richard Stallman
2008-01-06 10:46 ` Richard Stallman
2008-01-06 16:19 ` toggling a minor mode should not tell Customize that the value hasbeen set Drew Adams
2008-01-07 17:15 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbq7ysm0s.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.