From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Updated project-specific settings patch Date: Mon, 19 May 2008 17:57:06 -0400 Message-ID: References: <85lk26qbq3.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211234257 20420 80.91.229.12 (19 May 2008 21:57:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2008 21:57:37 +0000 (UTC) Cc: tromey@redhat.com, emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 19 23:58:14 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyDMz-0001dC-JN for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 23:58:13 +0200 Original-Received: from localhost ([127.0.0.1]:46533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyDMF-0006bq-K9 for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 17:57:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyDMB-0006an-O2 for emacs-devel@gnu.org; Mon, 19 May 2008 17:57:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyDMA-0006aH-9R for emacs-devel@gnu.org; Mon, 19 May 2008 17:57:23 -0400 Original-Received: from [199.232.76.173] (port=56894 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyDM9-0006a7-Up for emacs-devel@gnu.org; Mon, 19 May 2008 17:57:21 -0400 Original-Received: from 206-248-170-48.dsl.teksavvy.com ([206.248.170.48]:52672 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyDM7-0006K6-Kv; Mon, 19 May 2008 17:57:19 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 83C75B422F; Mon, 19 May 2008 17:57:08 -0400 (EDT) In-Reply-To: <85lk26qbq3.fsf@lola.goethe.zz> (David Kastrup's message of "Mon, 19 May 2008 22:29:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97413 Archived-At: >> Better use the same buffer name *Local Variables*. >> >>> + ((file-exists-p (concat dir ".dir-settings.el")) >>> + (setq result (concat dir ".dir-settings.el"))) >> >> In most cases, we'd prefer (expand-file-name ".dir-settings.el" dir) >> over the use of `concat'. The only exception I know is when `dir' is >> relative and it's important for the result also be relative. > If the file name or directory has been read directly from disk and thus > may contain "~" or "~USER" as valid literal components, you don't want > to have those expanded. That simply depends on what the result is used for. In 99% of the cases in Emacs, the difference between the two doesn't matter. Stefan