bug#1152: emacsclient should support the "-nw" flag

bug#1152: emacsclient should support the "-nw" flag

[Dan Nicolaescu]

emacsclient should support the "-nw" flag (as an equivalent to "-t") for
consistency with emacs.

The attached patch implements this.

Index: emacsclient.c
===================================================================
RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.132
diff -u -3 -p -u -p -r1.132 emacsclient.c
--- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
+++ emacsclient.c	13 Oct 2008 01:34:25 -0000
@@ -156,6 +156,7 @@ struct option longopts[] =
   { "help",	no_argument,	   NULL, 'H' },
   { "version",	no_argument,	   NULL, 'V' },
   { "tty",	no_argument,       NULL, 't' },
+  { "nw",	no_argument,       NULL, 't' },
   { "create-frame", no_argument,   NULL, 'c' },
   { "alternate-editor", required_argument, NULL, 'a' },
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
@@ -474,7 +475,7 @@ decode_options (argc, argv)
 
   while (1)
     {
-      int opt = getopt_long (argc, argv,
+      int opt = getopt_long_only (argc, argv,
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
 			     "VHnea:s:f:d:tc",
 #else
@@ -601,7 +602,7 @@ Every FILE can be either just a FILENAME
 The following OPTIONS are accepted:\n\
 -V, --version		Just print version info and return\n\
 -H, --help    		Print this usage information message\n\
--t, --tty    		Open a new Emacs frame on the current terminal\n\
+-nw, -t, --tty 		Open a new Emacs frame on the current terminal\n\
 -c, --create-frame    	Create a new frame instead of trying to\n\
 			use the current Emacs frame\n\
 -e, --eval    		Evaluate the FILE arguments as ELisp expressions\n\

bug#1152: emacsclient should support the "-nw" flag

[Stefan Monnier]

> emacsclient should support the "-nw" flag (as an equivalent to "-t") for
> consistency with emacs.

That's good, please install it,


        Stefan

bug#1152: marked as done (emacsclient should support the "-nw" flag)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]


Your message dated Sun, 12 Oct 2008 19:34:35 -0700 (PDT)
with message-id <200810130234.m9D2YZ5c000663@mothra.ics.uci.edu>
and subject line Re: bug#1152: emacsclient should support the "-nw" flag
has caused the Emacs bug report #1152,
regarding emacsclient should support the "-nw" flag
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1152: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1152
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3958 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs@gnu.org
Subject: emacsclient should support the "-nw" flag
Date: Sun, 12 Oct 2008 18:36:44 -0700 (PDT)
Message-ID: <200810130136.m9D1ahgF000541@mothra.ics.uci.edu>


emacsclient should support the "-nw" flag (as an equivalent to "-t") for
consistency with emacs.

The attached patch implements this.

Index: emacsclient.c
===================================================================
RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.132
diff -u -3 -p -u -p -r1.132 emacsclient.c
--- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
+++ emacsclient.c	13 Oct 2008 01:34:25 -0000
@@ -156,6 +156,7 @@ struct option longopts[] =
   { "help",	no_argument,	   NULL, 'H' },
   { "version",	no_argument,	   NULL, 'V' },
   { "tty",	no_argument,       NULL, 't' },
+  { "nw",	no_argument,       NULL, 't' },
   { "create-frame", no_argument,   NULL, 'c' },
   { "alternate-editor", required_argument, NULL, 'a' },
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
@@ -474,7 +475,7 @@ decode_options (argc, argv)
 
   while (1)
     {
-      int opt = getopt_long (argc, argv,
+      int opt = getopt_long_only (argc, argv,
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
 			     "VHnea:s:f:d:tc",
 #else
@@ -601,7 +602,7 @@ Every FILE can be either just a FILENAME
 The following OPTIONS are accepted:\n\
 -V, --version		Just print version info and return\n\
 -H, --help    		Print this usage information message\n\
--t, --tty    		Open a new Emacs frame on the current terminal\n\
+-nw, -t, --tty 		Open a new Emacs frame on the current terminal\n\
 -c, --create-frame    	Create a new frame instead of trying to\n\
 			use the current Emacs frame\n\
 -e, --eval    		Evaluate the FILE arguments as ELisp expressions\n\




[-- Attachment #3: Type: message/rfc822, Size: 2066 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1152-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1152: emacsclient should support the "-nw" flag
Date: Sun, 12 Oct 2008 19:34:35 -0700 (PDT)
Message-ID: <200810130234.m9D2YZ5c000663@mothra.ics.uci.edu>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > > emacsclient should support the "-nw" flag (as an equivalent to "-t") for
  > > consistency with emacs.
  > 
  > That's good, please install it,

Thanks, checked in.