From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2435: Bug 2435 Date: Thu, 05 Mar 2009 11:46:39 -0500 Message-ID: References: <87fxhvcmvf.fsf@cyd.mit.edu> <87zlg2a7b9.fsf@cyd.mit.edu> <87ab81293z.fsf@cyd.mit.edu> <877i34shq2.fsf@cyd.mit.edu> Reply-To: Stefan Monnier , 2435@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236273526 18717 80.91.229.12 (5 Mar 2009 17:18:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Mar 2009 17:18:46 +0000 (UTC) Cc: Chong Yidong , 2435@emacsbugs.donarmstrong.com To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 05 18:19:59 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LfHEY-0002uK-5W for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Mar 2009 18:19:46 +0100 Original-Received: from localhost ([127.0.0.1]:52116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfHDC-0006j7-NU for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Mar 2009 12:18:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfGzI-0000Dl-6h for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 12:04:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfGzG-0000Ci-6p for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 12:03:59 -0500 Original-Received: from [199.232.76.173] (port=39720 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfGzF-0000Ce-VG for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 12:03:57 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34117) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LfGzE-0005l3-FK for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 12:03:57 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n25H3deg027563; Thu, 5 Mar 2009 09:03:40 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n25Gt6ww025473; Thu, 5 Mar 2009 08:55:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 05 Mar 2009 16:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2435-submit@emacsbugs.donarmstrong.com id=B2435.123627160923917 (code B ref 2435); Thu, 05 Mar 2009 16:55:05 +0000 Original-Received: (at 2435) by emacsbugs.donarmstrong.com; 5 Mar 2009 16:46:49 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n25GkjSG023910 for <2435@emacsbugs.donarmstrong.com>; Thu, 5 Mar 2009 08:46:47 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqIEANOQr0nO+KX2/2dsb2JhbACBTtgRhAgGhBI X-IronPort-AV: E=Sophos;i="4.38,308,1233550800"; d="scan'208";a="34737504" Original-Received: from 206-248-165-246.dsl.teksavvy.com (HELO pastel.home) ([206.248.165.246]) by ironport2-out.teksavvy.com with ESMTP; 05 Mar 2009 11:46:40 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 9A4487FA2; Thu, 5 Mar 2009 11:46:39 -0500 (EST) In-Reply-To: (Kenichi Handa's message of "Thu, 05 Mar 2009 20:23:21 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 05 Mar 2009 12:03:59 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26014 Archived-At: > It will fix the current problem of bufp contents being > changed by recursive call, but we still have a danger of > Lisp code being called in re_compile_pattern, which may lead > to relocation of string data pointed by the arg "pattern". > So, I think we must avoid any Lisp calls within > re_compile_pattern. Indeed, tho it's not clear how we could do that. One way that occurs to me is: if we need to `load' or do some such dangerous operation in re_compile_pattern, signal an error so we exit re_compile_pattern. Then catch this error in the calling code where we can do the corresponding operation safely and call re_compile_pattern again. Kind of ugly, but for autoload-style operations it seems acceptable. Stefan