From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4446: remove ###autoload from ediff-hook.el Date: Wed, 16 Sep 2009 09:22:42 -0400 Message-ID: References: <200909161118.n8GBIPDV012011@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 4446@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253109425 31219 80.91.229.12 (16 Sep 2009 13:57:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Sep 2009 13:57:05 +0000 (UTC) Cc: bug-gnu-emacs , 4446@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 16 15:56:58 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mnv0C-0001gR-PH for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 15:56:57 +0200 Original-Received: from localhost ([127.0.0.1]:52984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mnv0C-0002cs-0N for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Sep 2009 09:56:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mnuqo-00049m-7s for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:47:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mnuqk-000460-EY for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:47:13 -0400 Original-Received: from [199.232.76.173] (port=40924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mnuqh-00045k-Ix for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:47:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35020) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mnuqg-0007Wx-Ap for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:47:07 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GDl0UE005476; Wed, 16 Sep 2009 06:47:01 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8GDU4O1002122; Wed, 16 Sep 2009 06:30:04 -0700 Resent-Date: Wed, 16 Sep 2009 06:30:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 16 Sep 2009 13:30:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4446 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.1253107371843 (code B ref -1); Wed, 16 Sep 2009 13:30:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 16 Sep 2009 13:22:51 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8GDMod8000840 for ; Wed, 16 Sep 2009 06:22:51 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnuTB-00043d-FX for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:22:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnuT5-00042x-LY for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:22:47 -0400 Original-Received: from [199.232.76.173] (port=49905 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnuT5-00042u-FZ for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:22:43 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:29263 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MnuT5-00031q-83 for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2009 09:22:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAM+DsEpFpZBe/2dsb2JhbACBU904hBcFh32CfA X-IronPort-AV: E=Sophos;i="4.44,397,1249272000"; d="scan'208";a="45761339" Original-Received: from 69-165-144-94.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.94]) by ironport2-out.pppoe.ca with ESMTP; 16 Sep 2009 09:22:42 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 54F11827E; Wed, 16 Sep 2009 09:22:42 -0400 (EDT) In-Reply-To: <200909161118.n8GBIPDV012011@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 16 Sep 2009 04:18:25 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Wed, 16 Sep 2009 09:47:13 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31140 Archived-At: > The ###autoload in ediff-hook.el is not needed, this file is in the > dumped image, so the autoload's only effect is to make loaddefs.el > bigger and increase the size of the dumped image. > The comment in the file says that the autoload is needed for XEmacs, but > that's not a good reason to keep it in the Emacs CVS, it's a one line > change to a file that almost never changes. > OK to remove the autoload line? Actually, it reminds me that I faced a similar situation recently. I did remove the autoload cookie, but in retrospect I think it was the wrong thing to do. We should instead teach our build system to skip preloaded files when creating the loaddefs.el file. Stefan