From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch) Date: Thu, 17 Sep 2009 10:06:05 -0400 Message-ID: References: <837hvyyfkd.fsf@gnu.org> <83zl8uwrx3.fsf@gnu.org> Reply-To: Stefan Monnier , 4448@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253197661 2132 80.91.229.12 (17 Sep 2009 14:27:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2009 14:27:41 +0000 (UTC) Cc: 4448@emacsbugs.donarmstrong.com To: "David J. Biesack" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 17 16:27:33 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoHxC-0006YE-NW for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 16:27:23 +0200 Original-Received: from localhost ([127.0.0.1]:46292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoHxB-0004lX-T3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 10:27:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoHx0-0004iR-Fy for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 10:27:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoHwv-0004gN-AO for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 10:27:09 -0400 Original-Received: from [199.232.76.173] (port=42746 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoHwv-0004gC-2e for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 10:27:05 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33489) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MoHwu-0006xN-Fo for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 10:27:04 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HER13N029641; Thu, 17 Sep 2009 07:27:02 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8HEF7mP027804; Thu, 17 Sep 2009 07:15:07 -0700 Resent-Date: Thu, 17 Sep 2009 07:15:07 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 17 Sep 2009 14:15:07 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4448 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4448-submit@emacsbugs.donarmstrong.com id=B4448.125319637326486 (code B ref 4448); Thu, 17 Sep 2009 14:15:07 +0000 Original-Received: (at 4448) by emacsbugs.donarmstrong.com; 17 Sep 2009 14:06:13 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HE6B0o026479 for <4448@emacsbugs.donarmstrong.com>; Thu, 17 Sep 2009 07:06:13 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq8EAK/esUpFxKiJ/2dsb2JhbACBU90xhBgFh38 X-IronPort-AV: E=Sophos;i="4.44,403,1249272000"; d="scan'208";a="45861789" Original-Received: from 69-196-168-137.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.137]) by ironport2-out.pppoe.ca with ESMTP; 17 Sep 2009 10:06:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id BAD2E827E; Thu, 17 Sep 2009 10:06:05 -0400 (EDT) In-Reply-To: (David J. Biesack's message of "Thu, 17 Sep 2009 08:58:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 17 Sep 2009 10:27:09 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31165 Archived-At: >> > If you have to modify the code to detect the situation and generate >> > an more meaningful error message, there should be clear >> > instructions on how to fix it.... which is still not very friendly. >> Run it through dos2unix or "flip -u", or even find-file-literally in >> Emacs, then remove all ^M characters and save. > Yes, I know how to convert; I have an elisp function named ^m that > does this, but it's an annoyance and it is unknown how many other > users will encounter this. Again, I assert that if Emacs created rmail > files with ^m in them, then Emacs should repair them, especially if > Emacs forces mbox conversion. Agreed. Of course, maybe the ^Ms were not added by Emacs but by your networked file system. Still, if the BABYL file worked fine with Emacs-22, I think we should try and make it work fine with Emacs-23 as well. Stefan