From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Sven Joachim <svenjoac@gmx.de>, 5365@debbugs.gnu.org
Subject: bug#5365: 23.1.91; Wrong type argument: keymapp, ("DEAD" . 35215396)
Date: Fri, 15 Jan 2010 12:52:48 -0500 [thread overview]
Message-ID: <jwvbpgv9rzs.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <873a27z63q.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 15 Jan 2010 11:27:05 -0500")
>>>> Indeed, that looks risky. Why don't we add this new kboard to the
>>>> all_kboards list before calling Qvendor_specific_keysyms?
>>> We'd still have to protect the terminal object.
>>
>> Why? It's a normal Lisp object, so it should be protected by the usual
>> GCPRO or stack marking, no?
>> [ Oddly enough, mark_terminal doesn't traverse the terminal's kboard. ]
> But the terminal object is removed from the terminal list before the
> call1 (this was before my latest patch):
But that's OK because the `terminal' variable is still on the stack so
the stack marking should see it and mark the corresponding terminal,
like any other Lisp object.
We should add a corresponding GCPRO, to make sure it also works without
conservative stack marking.
Stefan
next prev parent reply other threads:[~2010-01-15 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 14:58 bug#5365: 23.1.91; Wrong type argument: keymapp, ("DEAD" . 35215396) Sven Joachim
2010-01-13 10:03 ` Sven Joachim
2010-01-13 15:17 ` Stefan Monnier
2010-01-13 17:11 ` Chong Yidong
2010-01-13 17:27 ` Chong Yidong
2010-01-13 18:57 ` Stefan Monnier
2010-01-13 20:53 ` Chong Yidong
2010-01-14 4:21 ` Stefan Monnier
2010-01-15 16:27 ` Chong Yidong
2010-01-15 17:52 ` Stefan Monnier [this message]
2010-01-13 19:13 ` Sven Joachim
2010-01-13 18:46 ` Sven Joachim
-- strict thread matches above, loose matches on Subject: below --
2010-01-12 19:08 Chong Yidong
2010-01-12 19:39 ` Sven Joachim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbpgv9rzs.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=5365@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=svenjoac@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.