From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo <sdl.web@gmail.com>
Cc: 3274@debbugs.gnu.org, Daniel Colascione <dan.colascione@gmail.com>
Subject: bug#3274: ido-completing-read doesn't work unless ido-mode is executed
Date: Sun, 28 Nov 2010 15:50:19 -0500 [thread overview]
Message-ID: <jwvbp59uqgl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1wrnxmu5l.fsf@cam.ac.uk> (Leo's message of "Sun, 28 Nov 2010 13:53:26 +0000")
>> I also ran into this bug a while back but didn't stop to fix it.
>> Could you verify the following patch fixes the bug?
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -4853,6 +4853,9 @@ DEF, if non-nil, is the default value."
> (ido-directory-too-big nil)
> (ido-context-switch-command 'ignore)
> (ido-choice-list choices))
> + ;; Initialize ido before invoking ido-read-internal
> + (unless (keymapp ido-common-completion-map)
> + (let (ido-mode) (ido-mode 1)))
> (ido-read-internal 'list prompt hist def require-match initial-input)))
"(let (ido-mode) (ido-mode 1))" is an "ugly hack" (not only because it
calls (ido-mode 1) but because of the let-binding).
> Please consider this patch instead. While the previous fix is minimal it
> does a bit too much by calling (ido-mode 1).
Glad you found a better solution. Your patch looks good. Savannah is
down right now, so I'll install it later. Thanks.
Stefan
next prev parent reply other threads:[~2010-11-28 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 15:10 bug#3274: ido-completing-read doesn't work unless ido-mode is executed Daniel Colascione
2010-11-28 13:37 ` Leo
2010-11-28 13:53 ` Leo
2010-11-28 20:50 ` Stefan Monnier [this message]
2010-12-02 23:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbp59uqgl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3274@debbugs.gnu.org \
--cc=dan.colascione@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.