From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7840: SYMBOL_VALUE in terminal.c (was 23.2.91; default-terminal-coding-system not inherited by created terminals) Date: Mon, 14 Feb 2011 13:05:44 -0500 Message-ID: References: <87wrl423dm.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297706808 22251 80.91.229.12 (14 Feb 2011 18:06:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Feb 2011 18:06:48 +0000 (UTC) Cc: 7840@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 14 19:06:42 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp2or-0000Me-TG for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Feb 2011 19:06:42 +0100 Original-Received: from localhost ([127.0.0.1]:46817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp2or-0006Jw-6H for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Feb 2011 13:06:41 -0500 Original-Received: from [140.186.70.92] (port=55964 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp2of-0006A9-Lp for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 13:06:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pp2od-0004tM-U3 for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 13:06:29 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp2od-0004tB-Kl for bug-gnu-emacs@gnu.org; Mon, 14 Feb 2011 13:06:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pp2fV-0003vS-Sl; Mon, 14 Feb 2011 12:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Feb 2011 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7840-submit@debbugs.gnu.org id=B7840.129770620915072 (code B ref 7840); Mon, 14 Feb 2011 17:57:01 +0000 Original-Received: (at 7840) by debbugs.gnu.org; 14 Feb 2011 17:56:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp2fJ-0003v3-4g for submit@debbugs.gnu.org; Mon, 14 Feb 2011 12:56:49 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp2fG-0003us-Vb for 7840@debbugs.gnu.org; Mon, 14 Feb 2011 12:56:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJr9WE1MCqmX/2dsb2JhbACmC3S7O4VeBIUEjEWCdA X-IronPort-AV: E=Sophos;i="4.60,469,1291611600"; d="scan'208";a="91694199" Original-Received: from 76-10-169-151.dsl.teksavvy.com (HELO ceviche.home) ([76.10.169.151]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 14 Feb 2011 13:05:44 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 7554E66188; Mon, 14 Feb 2011 13:05:44 -0500 (EST) In-Reply-To: <87wrl423dm.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 12 Feb 2011 19:18:45 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 14 Feb 2011 12:57:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44120 Archived-At: >> * terminal.c (create_terminal): Use default-keyboard-coding-system >> and default-terminal-coding-system to initialize coding systems of >> the new terminal. (Bug#7840) >> >> ! keyboard_coding = SYMBOL_VALUE (intern ("default-keyboard-coding-system")); >> ! if (NILP (keyboard_coding) >> ! || EQ (keyboard_coding, Qunbound) >> ! || NILP (Fcoding_system_p (keyboard_coding))) >> ! keyboard_coding = Qno_conversion; >> ! terminal_coding = SYMBOL_VALUE (intern ("default-terminal-coding-system")); > This change doesn't build on the trunk, due to Stefan's 2010-04-20 > change removing SYMBOL_VALUE. > I left out this change when doing the last merge from the branch. Would > you mind working up a separate patch and applying it to the trunk? > (Fsymbol_value apparently doesn't work here, because the symbols can be > unbound and we don't want to signal an error.) We can just use Fboundp tests, when needed. Stefan