all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#5777: 23.1.90; find-dired prompt bug
@ 2010-03-26 14:33 Stefan Guath
  2010-03-28 19:32 ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Guath @ 2010-03-26 14:33 UTC (permalink / raw)
  To: 5777

emacs-version: GNU Emacs 23.1.90.1 (x86_64-apple-darwin10.2.0, NS apple-appkit-1038.25) of 2010-02-23

To trigger bug:
emacs -Q
M-x ido-mode
M-x ido-everywhere
M-x find-dired

Bug symptons:
Impossible to choose directory since 'current directory' (.) is not in the ido-alternatives. Pressing return just enters the directory rather than
choosing it.

Bug reason:
In find-dired (find-dired.el): The first prompt argument in interactive is read-file-name.

Bug solution:
In find-dired (find-dired.el): The first prompt argument in interactive should be read-directory-name.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5777: 23.1.90; find-dired prompt bug
  2010-03-26 14:33 bug#5777: 23.1.90; find-dired prompt bug Stefan Guath
@ 2010-03-28 19:32 ` Chong Yidong
  2011-10-21 12:50   ` Stefan Guath
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2010-03-28 19:32 UTC (permalink / raw)
  To: Stefan Guath; +Cc: 5777-done

> emacs -Q
> M-x ido-mode
> M-x ido-everywhere
> M-x find-dired
>
> Bug symptons:
> Impossible to choose directory since 'current directory' (.) is not in
> the ido-alternatives. Pressing return just enters the directory rather
> than choosing it.
>
> Bug reason:
> In find-dired (find-dired.el): The first prompt argument in
> interactive is read-file-name.
>
> Bug solution:
> In find-dired (find-dired.el): The first prompt argument in
> interactive should be read-directory-name.

Thanks for reporting the bug, and investigating.  I've checked the fix
into the trunk.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5777: 23.1.90; find-dired prompt bug
  2010-03-28 19:32 ` Chong Yidong
@ 2011-10-21 12:50   ` Stefan Guath
  2011-10-21 16:14     ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Guath @ 2011-10-21 12:50 UTC (permalink / raw)
  To: 5777, Chong Yidong

Hi,

When looking in command find-dired in find-dired.el, the bug is still there (running GNU Emacs 23.3.1 x86_64-apple-darwin, NS apple-appkit-1038.35 of 2011-03-10)

Regards,

/Stefan Guath

On 28 mar 2010, at 21:32, Chong Yidong wrote:

>> emacs -Q
>> M-x ido-mode
>> M-x ido-everywhere
>> M-x find-dired
>> 
>> Bug symptons:
>> Impossible to choose directory since 'current directory' (.) is not in
>> the ido-alternatives. Pressing return just enters the directory rather
>> than choosing it.
>> 
>> Bug reason:
>> In find-dired (find-dired.el): The first prompt argument in
>> interactive is read-file-name.
>> 
>> Bug solution:
>> In find-dired (find-dired.el): The first prompt argument in
>> interactive should be read-directory-name.
> 
> Thanks for reporting the bug, and investigating.  I've checked the fix
> into the trunk.
> 






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5777: 23.1.90; find-dired prompt bug
  2011-10-21 12:50   ` Stefan Guath
@ 2011-10-21 16:14     ` Glenn Morris
  2011-10-21 17:54       ` Stefan Guath
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2011-10-21 16:14 UTC (permalink / raw)
  To: Stefan Guath; +Cc: 5777

Stefan Guath wrote:

> When looking in command find-dired in find-dired.el, the bug is still
> there (running GNU Emacs 23.3.1 x86_64-apple-darwin, NS
> apple-appkit-1038.35 of 2011-03-10)

The fix was never in the Emacs 23 branch. It will be in Emacs 24.
You might like to try http://alpha.gnu.org/gnu/emacs/pretest/ .






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5777: 23.1.90; find-dired prompt bug
  2011-10-21 16:14     ` Glenn Morris
@ 2011-10-21 17:54       ` Stefan Guath
  2011-10-21 19:14         ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Guath @ 2011-10-21 17:54 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 5777

Ok, thanks! I reverted from 24 to 23 because font-lock was too slow... Hope that will improve. Thanks for a fantastic product - you're doing an incredible work!

/s

On 21 okt 2011, at 18:14, Glenn Morris wrote:

> Stefan Guath wrote:
> 
>> When looking in command find-dired in find-dired.el, the bug is still
>> there (running GNU Emacs 23.3.1 x86_64-apple-darwin, NS
>> apple-appkit-1038.35 of 2011-03-10)
> 
> The fix was never in the Emacs 23 branch. It will be in Emacs 24.
> You might like to try http://alpha.gnu.org/gnu/emacs/pretest/ .
> 






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#5777: 23.1.90; find-dired prompt bug
  2011-10-21 17:54       ` Stefan Guath
@ 2011-10-21 19:14         ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-10-21 19:14 UTC (permalink / raw)
  To: Stefan Guath; +Cc: 5777

> Ok, thanks! I reverted from 24 to 23 because font-lock was too slow... Hope
> that will improve.

I don't know of any pending bug report about font-lock being slow, so
it's unlikely to improve.  Are you talking about slowness of processing
of the output of find-dired (which should still be about as fast/slow
with or without font-lock)?


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-21 19:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 14:33 bug#5777: 23.1.90; find-dired prompt bug Stefan Guath
2010-03-28 19:32 ` Chong Yidong
2011-10-21 12:50   ` Stefan Guath
2011-10-21 16:14     ` Glenn Morris
2011-10-21 17:54       ` Stefan Guath
2011-10-21 19:14         ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.