Tool-bar separators and :visible etc

Tool-bar separators and :visible etc

[Glenn Morris]

I'm trying to document the NEWS entry: "Tool-bars can display separators."

This works (after hiding and showing the tool-bar):
(define-key-after tool-bar-map [sep1] '("--")) 

so does this:
(define-key-after tool-bar-map [sep1] '(menu-item "--"))

This doesn't:
(define-key-after tool-bar-map [sep1] '(menu-item "--" nil :visible t))

although it does in a menu-bar:
(define-key-after menu-bar-help-menu [sep1] '(menu-item "--" nil :visible t))


So, it seems that tool-bar separator items do not support specifiers
like :visible, :help, etc. Is that correct?

Re: Tool-bar separators and :visible etc

[Glenn Morris]

Glenn Morris wrote:

> So, it seems that tool-bar separator items do not support specifiers
> like :visible, :help, etc. Is that correct?

From looking at parse_tool_bar_item, it looks like that is correct.
Only plain "--" is supported.

Re: Tool-bar separators and :visible etc

[Stefan Monnier]

> This works (after hiding and showing the tool-bar):
> (define-key-after tool-bar-map [sep1] '("--")) 

> so does this:
> (define-key-after tool-bar-map [sep1] '(menu-item "--"))

> This doesn't:
> (define-key-after tool-bar-map [sep1] '(menu-item "--" nil :visible t))

> although it does in a menu-bar:
> (define-key-after menu-bar-help-menu [sep1] '(menu-item "--" nil :visible t))

> So, it seems that tool-bar separator items do not support specifiers
> like :visible, :help, etc. Is that correct?

I think that's right, but the discrepancy with men-bar items points to
the fact that we need to better design&document what we mean by
a separator and how to distinguish it from an entry whose name is "--".


        Stefan