From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-image): Allow viewing large images. Date: Mon, 13 Feb 2012 16:24:26 -0500 Message-ID: References: <874nuuwlib.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1329168277 11186 80.91.229.3 (13 Feb 2012 21:24:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Feb 2012 21:24:37 +0000 (UTC) Cc: Katsumi Yamaoka , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 13 22:24:35 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rx3Nx-0002Vr-NB for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2012 22:24:33 +0100 Original-Received: from localhost ([::1]:47411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx3Nw-0005lu-H2 for ged-emacs-devel@m.gmane.org; Mon, 13 Feb 2012 16:24:32 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx3Nu-0005le-0C for emacs-devel@gnu.org; Mon, 13 Feb 2012 16:24:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rx3Ns-0001NU-F8 for emacs-devel@gnu.org; Mon, 13 Feb 2012 16:24:29 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rx3Ns-0001NG-9k for emacs-devel@gnu.org; Mon, 13 Feb 2012 16:24:28 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q1DLOQ7X032008; Mon, 13 Feb 2012 16:24:26 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id BAEBE130009; Mon, 13 Feb 2012 16:24:26 -0500 (EST) In-Reply-To: <874nuuwlib.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 13 Feb 2012 21:01:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4131=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4131> : streams <728329> : uri <1064811> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148581 Archived-At: >> The whole purpose of max-image-size was to avoid crashes and >> denial-of-service, for example when viewing incorrectly-labeled images. >> So it's especially important for SHR which will display images >> downloaded from anywhere. > shr.el (if compiled with imagemagick support) will (by default) rescale > the images down. But to do that, it goes through the display engine, > anyway, so it's an issue anyway. > But what crashes and denials of service does `create-image' on a large > image result in? We had a few bug reports: some incorrectly labeled images seemed to indicate insanely large size, which resulted in crashes because malloc failed, while other large images resulted in problems because of allocation of very large blocks of memory for the image. A quick search pointed me to the thread at http://www.mail-archive.com/emacs-devel@gnu.org/msg10214.html which doesn't show concrete bugs, but should give you some context. Stefan