From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11520: 24.1.50; delete-selection-mode conflicts with electric-pair-mode Date: Mon, 22 Oct 2012 08:46:39 -0400 Message-ID: References: <87ipdqx6e4.fsf@gnu.org> <87a9z19jgj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350910052 23867 80.91.229.3 (22 Oct 2012 12:47:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Oct 2012 12:47:32 +0000 (UTC) Cc: Chong Yidong , 11520-done@debbugs.gnu.org To: Simon Law Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 22 14:47:39 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQHPt-0001M3-RU for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 14:47:37 +0200 Original-Received: from localhost ([::1]:48381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQHPl-0006wX-Cz for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 08:47:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQHPd-0006wO-JY for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 08:47:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQHPZ-0006dV-Ac for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 08:47:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQHPZ-0006dN-6g for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 08:47:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQHRG-0006n8-TC for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 08:49:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Oct 2012 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 11520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 11520@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 11520-done@debbugs.gnu.org id=D11520.135091011626052 (code D ref 11520); Mon, 22 Oct 2012 12:49:02 +0000 Original-Received: (at 11520-done) by debbugs.gnu.org; 22 Oct 2012 12:48:36 +0000 Original-Received: from localhost ([127.0.0.1]:55353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQHQp-0006m8-Pz for submit@debbugs.gnu.org; Mon, 22 Oct 2012 08:48:36 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52073) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQHQl-0006lm-N8 for 11520-done@debbugs.gnu.org; Mon, 22 Oct 2012 08:48:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiYGAG6Zu09FpYC//2dsb2JhbABEr1pug0mBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202451526" Original-Received: from 69-165-128-191.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.128.191]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Oct 2012 08:46:39 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 279D0AE4B0; Mon, 22 Oct 2012 08:46:39 -0400 (EDT) In-Reply-To: (Simon Law's message of "Sun, 21 Oct 2012 19:12:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65840 Archived-At: > Attached is a patch against trunk. Thanks, I really appreciate the addition of docstrings. it's got a few cosmetic problems, so I've installed it and then installed a subsequent patch on top of it. Here are the issues I noticed: - a hook is a symbol whose value contains a list of functions (modulo a few subtleties). The functions themselves are not hooks. E.g. delete-selection-pre-hook is not a hook, just a function that's typically added on a particular hook. And the symbol symbol is named with "-hook" (rather than with "-hooks") for normal hooks and "-functions" for abnormal hooks. - symbols in docstrings are written `foo' rather than 'foo. - docstrings normally don't end with a line-separator (i.e. the closing " should not be on its own line). - there's no self-insert-iso in Emacs, so I'd rather not touch it. - use the imperative for the first line of a docstring. - `keep' is not a value handled specially by delete-selection-helper, so it is handled as a hook, luckily there's no function on this hook (an unbound symbol is treated by `run-hook' as a symbol bound to nil) so it ends up behaving like nil, which is indeed what we need; so the end behavior is correct, but only "by accident". Stefan