From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: Josh <josh@foxtail.org>, 13078@debbugs.gnu.org
Subject: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces
Date: Tue, 04 Dec 2012 23:16:19 -0500 [thread overview]
Message-ID: <jwvboe9qgmv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <bofw3lmf7d.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 04 Dec 2012 20:59:34 -0500")
>> - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
>> + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then
I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well.
In my experience, $FOO variable references in sh scripts need to be
wrapped inside "..." by default to avoid such problem.
Stefan
next prev parent reply other threads:[~2012-12-05 4:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 4:35 bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Josh
2012-12-05 1:59 ` Glenn Morris
2012-12-05 4:16 ` Stefan Monnier [this message]
2012-12-05 4:40 ` Glenn Morris
2012-12-05 5:01 ` Stefan Monnier
2012-12-05 5:13 ` Josh
2012-12-09 2:28 ` Paul Eggert
2012-12-09 4:14 ` Josh
2012-12-09 7:57 ` Andreas Schwab
2012-12-09 9:05 ` Paul Eggert
2012-12-09 11:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvboe9qgmv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13078@debbugs.gnu.org \
--cc=josh@foxtail.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.