From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14156: 24.3.50; Timer firing after being canceled Date: Sun, 07 Apr 2013 22:09:01 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365445675 4286 80.91.229.3 (8 Apr 2013 18:27:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Apr 2013 18:27:55 +0000 (UTC) Cc: 14156@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 08 20:27:58 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UPGnA-0000pw-Sw for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2013 20:27:45 +0200 Original-Received: from localhost ([::1]:59848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UP1Wg-0003bh-H7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2013 22:09:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UP1Wb-0003bO-Bu for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2013 22:09:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UP1WX-0003Oo-NP for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2013 22:09:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UP1WX-0003Ok-K5 for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2013 22:09:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UP1Zu-0006EF-En for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2013 22:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2013 02:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14156-submit@debbugs.gnu.org id=B14156.136538715523909 (code B ref 14156); Mon, 08 Apr 2013 02:13:02 +0000 Original-Received: (at 14156) by debbugs.gnu.org; 8 Apr 2013 02:12:35 +0000 Original-Received: from localhost ([127.0.0.1]:39124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UP1ZS-0006DZ-Kt for submit@debbugs.gnu.org; Sun, 07 Apr 2013 22:12:35 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37681) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UP1ZQ-0006DR-MJ for 14156@debbugs.gnu.org; Sun, 07 Apr 2013 22:12:33 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r38291Xb009062; Sun, 7 Apr 2013 22:09:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A115667A13; Sun, 7 Apr 2013 22:09:01 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 07 Apr 2013 20:50:37 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4542=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4542> : streams <936693> : uri <1387909> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73263 Archived-At: > If you call `start-the-timer', you get the message "Why is this ever > reached?" over and over. This obviously should not happen. As mentioned elsewhere, this seems to be due to patch revno: 110138 fixes bugs: http://debbugs.gnu.org/12447 http://debbugs.gnu.org/12326 I installed the patch below which seems to fix it. Stefan === modified file 'lisp/emacs-lisp/timer.el' --- lisp/emacs-lisp/timer.el 2013-01-13 01:23:48 +0000 +++ lisp/emacs-lisp/timer.el 2013-04-08 01:53:53 +0000 @@ -314,7 +314,11 @@ (save-current-buffer (apply (timer--function timer) (timer--args timer))) (error (message "Error in timer: %S" err))) - (if retrigger + (when (and retrigger + ;; If the timer's been canceled, don't "retrigger" it + ;; since it might still be in the copy of timer-list kept + ;; by keyboard.c:timer_check (bug#14156). + (memq timer timer-list)) (setf (timer--triggered timer) nil))) (error "Bogus timer event"))))