From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14714: 24.3.50; `isearch-filter-predicate(s)' Date: Tue, 25 Jun 2013 14:46:49 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372186028 15234 80.91.229.3 (25 Jun 2013 18:47:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Jun 2013 18:47:08 +0000 (UTC) Cc: 14714@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 20:47:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrYGi-0001fP-5U for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 20:47:08 +0200 Original-Received: from localhost ([::1]:46589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYGh-00089h-RD for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 14:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYGe-00089S-5q for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 14:47:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrYGc-0005J2-S0 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 14:47:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrYGc-0005Iy-OD for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UrYGc-0006mo-A1 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2013 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14714-submit@debbugs.gnu.org id=B14714.137218601226070 (code B ref 14714); Tue, 25 Jun 2013 18:47:02 +0000 Original-Received: (at 14714) by debbugs.gnu.org; 25 Jun 2013 18:46:52 +0000 Original-Received: from localhost ([127.0.0.1]:40924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrYGR-0006mQ-SB for submit@debbugs.gnu.org; Tue, 25 Jun 2013 14:46:52 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33846) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrYGP-0006mI-Sg for 14714@debbugs.gnu.org; Tue, 25 Jun 2013 14:46:50 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r5PIklFb028300; Tue, 25 Jun 2013 14:46:47 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 18877B4178; Tue, 25 Jun 2013 14:46:49 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Tue, 25 Jun 2013 10:26:15 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4620=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4620> : streams <988850> : uri <1458362> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75585 Archived-At: > 1. `isearch-filter-predicates' should not be an _alias_ for > `isearch-filter-predicate'. The former cannot just replace the latter. Actually, shouldn't we revert this change and use (add-function :before-while ...) on isearch-filter-predicate instead? Admittedly, currently nadvice.el does not give you access to the list of functions so you can't directly do the equivalent of (mapconcat (lambda (s) (and (symbolp s) (get s 'isearch-message-prefix))) (if (consp isearch-filter-predicates) isearch-filter-predicates (list isearch-filter-predicates)) "") but that could be remedied (even using an advice's property rather than a symbol property on the function added as advice). Stefan