From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ivan Kanis <ivan@kanis.fr>
Cc: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>,
"Lars Ingebrigtsen" <larsi@gnus.org>,
emacs-devel@gnu.org
Subject: Re: [PATCH] render region with eww
Date: Thu, 27 Jun 2013 15:03:39 -0400 [thread overview]
Message-ID: <jwvbo6r4brc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mwqbcu0x.fsf_-_@kanis.fr> (Ivan Kanis's message of "Thu, 27 Jun 2013 20:01:34 +0200")
> +(defun shr-render-region (begin end &optional buffer)
> + "Display the HTML rendering of the region between BEGIN and END."
> + (interactive "r")
> + (unless (fboundp 'libxml-parse-html-region)
> + (error "This function requires Emacs to be compiled with libxml2"))
> + (with-current-buffer (or buffer (current-buffer))
> + (let ((dom (libxml-parse-html-region begin end)))
> + (kill-region begin end)
> + (goto-char begin)
> + (shr-insert-document dom))))
I think this should use delete-region, not kill-region.
Stefan
next prev parent reply other threads:[~2013-06-27 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:04 render region with eww Ivan Kanis
2013-06-26 9:00 ` Rüdiger Sonderfeld
2013-06-27 18:01 ` [PATCH] " Ivan Kanis
2013-06-27 19:03 ` Stefan Monnier [this message]
2013-06-28 7:59 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbo6r4brc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ivan@kanis.fr \
--cc=larsi@gnus.org \
--cc=ruediger@c-plusplus.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.