From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Date: Fri, 16 Aug 2013 12:25:43 -0400 Message-ID: References: <2aaa3bfa-1556-4135-b70a-1308e6cc7cdd@default> <8738qb816m.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376670387 2865 80.91.229.3 (16 Aug 2013 16:26:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Aug 2013 16:26:27 +0000 (UTC) Cc: 14926@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 18:26:27 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VAMr5-00065y-8g for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2013 18:26:27 +0200 Original-Received: from localhost ([::1]:60117 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMr4-00026K-SU for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2013 12:26:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMqv-0001yD-2Z for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 12:26:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAMqh-0007a0-AX for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 12:26:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAMqh-0007Zq-79 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 12:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VAMqg-0001pc-G4 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2013 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2013 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14926-submit@debbugs.gnu.org id=B14926.13766703487006 (code B ref 14926); Fri, 16 Aug 2013 16:26:02 +0000 Original-Received: (at 14926) by debbugs.gnu.org; 16 Aug 2013 16:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:34905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VAMqR-0001ov-9P for submit@debbugs.gnu.org; Fri, 16 Aug 2013 12:25:47 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47554) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VAMqO-0001oi-T5 for 14926@debbugs.gnu.org; Fri, 16 Aug 2013 12:25:45 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r7GGPhBB022452; Fri, 16 Aug 2013 12:25:43 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A57E7B44A4; Fri, 16 Aug 2013 12:25:43 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Fri, 16 Aug 2013 09:45:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4672=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4672> : streams <1020695> : uri <1508495> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77434 Archived-At: > The message still suggests that using make-variable-buffer-local other > than at toplevel is erroneous. Notice that the message is only emitted when the argument to the" function is a constant. I know of only one case where it is "not erroneous" to have such a call not at top-level (from message.el): ;; FIXME: On XEmacs this causes problems since let-binding like: ;; (let ((message-options message-options)) ...) ;; as in `message-send' and `mml-preview' loses to buffer-local ;; variable initialization. (unless (featurep 'xemacs) (make-variable-buffer-local 'message-options)) So yes, I think in 99% of the cases, it's erroneous. Stefan