bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"

[Stefan Monnier <monnier@IRO.UMontreal.CA>]

> The message still suggests that using make-variable-buffer-local other
> than at toplevel is erroneous.

Notice that the message is only emitted when the argument to the"
function is a constant.  I know of only one case where it is "not
erroneous" to have such a call not at top-level (from message.el):

   ;; FIXME: On XEmacs this causes problems since let-binding like:
   ;; (let ((message-options message-options)) ...)
   ;; as in `message-send' and `mml-preview' loses to buffer-local
   ;; variable initialization.
   (unless (featurep 'xemacs)
     (make-variable-buffer-local 'message-options))

So yes, I think in 99% of the cases, it's erroneous.


        Stefan