From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14892: [PATCH] Enhance Elisp compare functions (< <= > >=) to take var args Date: Tue, 10 Sep 2013 16:16:02 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378844242 27405 80.91.229.3 (10 Sep 2013 20:17:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Sep 2013 20:17:22 +0000 (UTC) Cc: 14892@debbugs.gnu.org To: Barry OReilly Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 10 22:17:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VJUNG-00078J-FT for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Sep 2013 22:17:22 +0200 Original-Received: from localhost ([::1]:59877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJUNF-0002w2-Tw for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Sep 2013 16:17:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJUN4-0002js-Ao for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 16:17:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJUMx-0005eT-0i for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 16:17:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJUMw-0005eM-OR for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 16:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VJUMw-00054r-7V for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 16:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Sep 2013 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14892-submit@debbugs.gnu.org id=B14892.137884416619443 (code B ref 14892); Tue, 10 Sep 2013 20:17:02 +0000 Original-Received: (at 14892) by debbugs.gnu.org; 10 Sep 2013 20:16:06 +0000 Original-Received: from localhost ([127.0.0.1]:53315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJUM2-00053X-1e for submit@debbugs.gnu.org; Tue, 10 Sep 2013 16:16:06 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:56605) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJULz-00053P-Rv for 14892@debbugs.gnu.org; Tue, 10 Sep 2013 16:16:04 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r8AKG2NZ013219; Tue, 10 Sep 2013 16:16:03 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id AABD1B40D6; Tue, 10 Sep 2013 16:16:02 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Tue, 10 Sep 2013 10:54:02 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4697=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4697> : inlines <79> : streams <1035083> : uri <1532967> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78191 Archived-At: >> Looking at your patch a second time, I don't see how/where it >> handles (< a b c) in byte-compiled code: the byte-codes only >> handle 2-arguments, and the byte-compiler is left unchanged. > (disassemble (byte-compile (lambda () (< x y)))) > byte code: > args: nil > 0 varref x > 1 varref y > 2 lss > 3 return > (disassemble (byte-compile (lambda () (< x y z)))) > byte code: > args: nil > 0 constant < > 1 varref x > 2 varref y > 3 varref z > 4 call 3 > 5 return Ha! Indeed, it does! great! So could you change the bytecode.c code along the lines I suggested so as to eliminate the slight speed penalty? Stefan