From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13594: Planning Emacs-24.4 Date: Mon, 18 Nov 2013 08:55:44 -0500 Message-ID: References: <5289F003.5040708@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1384783015 13399 80.91.229.3 (18 Nov 2013 13:56:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Nov 2013 13:56:55 +0000 (UTC) Cc: 13594@debbugs.gnu.org, Leo Liu To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 18 14:56:59 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ViPJw-0003DA-C5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2013 14:56:56 +0100 Original-Received: from localhost ([::1]:43552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViPJt-000092-1l for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2013 08:56:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViPJG-0007tq-SN for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 08:56:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViPJ9-000233-F7 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 08:56:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViPJ9-00022t-Co for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 08:56:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ViPJ5-0000WW-3q for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2013 08:56:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2013 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13594-submit@debbugs.gnu.org id=B13594.13847829551999 (code B ref 13594); Mon, 18 Nov 2013 13:56:02 +0000 Original-Received: (at 13594) by debbugs.gnu.org; 18 Nov 2013 13:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:59687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViPIw-0000WA-Bd for submit@debbugs.gnu.org; Mon, 18 Nov 2013 08:55:54 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:27853) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViPIs-0000Vv-T5 for 13594@debbugs.gnu.org; Mon, 18 Nov 2013 08:55:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KWN/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFHO+KWN/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="38499060" Original-Received: from 206-248-165-141.dsl.teksavvy.com (HELO pastel.home) ([206.248.165.141]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Nov 2013 08:55:45 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D089D60466; Mon, 18 Nov 2013 08:55:44 -0500 (EST) In-Reply-To: <5289F003.5040708@gmx.at> (martin rudalics's message of "Mon, 18 Nov 2013 11:46:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80731 Archived-At: >> Implemented as requested. I have also briefly tested with ggtags and it >> worked. Comments welcome. Thanks. Thank you. Two comments: 1- You can/should use nil instead of `ignore'. 2- I'm not sure `may-fail' is the right name. After all, it's not really a failure, but rather a conscious (and successful) decision to not display the buffer. I don't have a good counter-proposition, tho ("no-display-ok" is what comes to my mind, but I don't like it too much either). > Why didn't you implement the may-fail part? IIUC `display-buffer' > should *not* return nil unless may-fail has been set. So if may-fail is > not set, `display-buffer' should either create a new window, a new > frame, or reuse some window at any cost. AFAICT, display-buffer does already try pretty hard. I think that if display-buffer returns nil in a context where may-fail is nil, it's not a bug in display-buffer but in some of the ACTIONS, and I see no reason why `display-buffer' should try and cover up the problem. > And there's no use for `display-buffer' returning t. You mean, it should return nil (and never t) if the return value is not a window? I guess it would indeed be cleaner, yes, Stefan