From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115287: * lisp/emacs-lisp/helpers.el (string-empty-p): New function. Date: Fri, 29 Nov 2013 13:23:55 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385749449 11580 80.91.229.3 (29 Nov 2013 18:24:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 18:24:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 19:24:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmSje-00042O-7E for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 19:24:14 +0100 Original-Received: from localhost ([::1]:48952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmSjd-00044R-Ot for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 13:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmSjU-0003s4-DT for emacs-devel@gnu.org; Fri, 29 Nov 2013 13:24:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmSjN-0002re-3H for emacs-devel@gnu.org; Fri, 29 Nov 2013 13:24:04 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:27159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmSjM-0002ra-VZ for emacs-devel@gnu.org; Fri, 29 Nov 2013 13:23:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA4hhnBmBXoMV X-IPAS-Result: Av4EABK/CFHO+KEh/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40705850" Original-Received: from 206-248-161-33.dsl.teksavvy.com (HELO pastel.home) ([206.248.161.33]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Nov 2013 13:23:56 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 1C83060EFA; Fri, 29 Nov 2013 13:23:56 -0500 (EST) In-Reply-To: (Bozhidar Batsov's message of "Fri, 29 Nov 2013 16:52:32 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165891 Archived-At: > + (string= string "")) I think `equal' is preferable since it avoids signaling an error if STRING is not a string. > +(defsubst string-blank-p (string) > + "Check whether STRING is either empty or only whitespace." > + (string-empty-p (string-trim string))) Better use (string-match-p "\\`...\\'" string) to avoid allocating a new string. Stefan