From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: 16411@debbugs.gnu.org
Subject: bug#16411: undo-only bugs
Date: Fri, 10 Jan 2014 18:54:57 -0500 [thread overview]
Message-ID: <jwvbnzj5rlu.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAFM41H1m2EHLZHq=0pPeGaQ0pic6KE5j6fiAWM_nBP5JZWh8+g@mail.gmail.com> (Barry OReilly's message of "Fri, 10 Jan 2014 17:33:37 -0500")
> I think the solution entails moving this sort of thing into a loop in
> undo-more:
> (when (and (consp equiv) undo-no-redo)
> ;; The equiv entry might point to another redo record if we have done
> ;; undo-redo-undo-redo-... so skip to the very last equiv.
> (while (let ((next (gethash equiv undo-equiv-table)))
> (if next (setq equiv next))))
> (setq pending-undo-list equiv))
Indeed. Or, equivalently, changing `undo' so it only calls undo-more with
argument 1 (and use the above while loop between each call to undo-more).
> Recipe 2:
> • Insert "aaa"
> • Insert "bbb"
> • Mark region around "aaa" but not "bbb"
> • Undo (in region)
> • Mark region around "bbb" and where "aaa" used to be
> • Undo-only
> • Expected: none of the above insertions are in the buffer
> • Actual: buffer has aaa and bbb insertions
> The code appears to simply punt on undo-only in region and behaves
> like ordinary undo. Thus it undoes the redo record to bring back bbb.
undo-in-region does not implement undo-only, indeed. I think the way to
implement undo-only is to change undo-make-selective-list so it also
skips redo entries (depending on undo-no-redo, obviously) using the
above while loop.
Stefan
next prev parent reply other threads:[~2014-01-10 23:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 22:33 bug#16411: undo-only bugs Barry OReilly
2014-01-10 23:54 ` Stefan Monnier [this message]
2014-01-11 3:48 ` Barry OReilly
2014-01-11 4:29 ` Stefan Monnier
2014-01-11 5:09 ` Barry OReilly
2014-01-14 0:49 ` Stefan Monnier
2014-01-14 1:52 ` Stefan Monnier
2014-01-14 14:00 ` Barry OReilly
2014-01-19 0:58 ` Barry OReilly
2014-01-19 3:18 ` Stefan Monnier
2014-01-19 16:57 ` Barry OReilly
2014-02-14 18:51 ` Barry OReilly
2014-02-14 22:29 ` Barry OReilly
2014-02-18 17:40 ` Barry OReilly
2014-02-26 15:20 ` bug#16411: undo in region corrupts existing text Barry OReilly
2014-02-27 5:02 ` Stefan Monnier
2014-05-13 15:01 ` bug#16411: undo-only bugs Barry OReilly
2014-05-14 18:06 ` Stefan Monnier
2014-05-14 18:45 ` Stefan Monnier
2014-05-14 19:55 ` Stefan Monnier
2014-05-14 21:56 ` Barry OReilly
2014-05-15 2:23 ` Stefan Monnier
2014-05-15 3:51 ` Barry OReilly
2014-05-15 13:00 ` Stefan Monnier
2014-05-28 18:42 ` Barry OReilly
2014-06-19 21:35 ` Stefan Monnier
2014-05-14 13:32 ` Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbnzj5rlu.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16411@debbugs.gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.