all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#10772: 24.0.93; [patch] Convert tcl-auto-fill-mode to use define-minor-mode
@ 2012-02-09  6:49 William Stevenson
  2012-02-09 15:18 ` Juanma Barranquero
  2012-02-09 22:09 ` Stefan Monnier
  0 siblings, 2 replies; 16+ messages in thread
From: William Stevenson @ 2012-02-09  6:49 UTC (permalink / raw)
  To: 10772

In the documentation of auto-fill-mode it says:
"When `auto-fill-mode' is on, the `auto-fill-function' variable is
non-`nil'."
Which makes the `if' redundant in this case, the THEN & ELSE bodies can
be placed below the call to turn auto-fill-mode on/off.

Also updated the documentation to reflect the auto generated
`tcl-auto-fill-mode-hook'.


=== modified file 'lisp/progmodes/tcl.el'
--- lisp/progmodes/tcl.el	2012-01-19 07:21:25 +0000
+++ lisp/progmodes/tcl.el	2012-02-09 06:18:32 +0000
@@ -1408,13 +1408,18 @@
 		     tcl-application file tcl-command-switches)
 	(if and-go (switch-to-tcl t)))))))
 
-(defun tcl-auto-fill-mode (&optional arg)
-  "Like `auto-fill-mode', but sets `comment-auto-fill-only-comments'."
-  (interactive "P")
-  (auto-fill-mode arg)
-  (if auto-fill-function
-      (set (make-local-variable 'comment-auto-fill-only-comments) t)
-    (kill-local-variable 'comment-auto-fill-only-comments)))
+(define-minor-mode tcl-auto-fill-mode
+  "Like `auto-fill-mode', but sets `comment-auto-fill-only-comments'.
+Turning the mode on or off runs `tcl-auto-fill-mode-hook'."
+  :init-value nil
+  (cond ((null tcl-auto-fill-mode)
+	 ;; Turn mode off
+	 (auto-fill-mode 0)
+	 (kill-local-variable 'comment-auto-fill-only-comments))
+	(t
+	 ;; Turn mode on
+	 (auto-fill-mode)
+	 (set (make-local-variable 'comment-auto-fill-only-comments) t))))
 
 (defun tcl-electric-hash (&optional count)
   "Insert a `#' and quote if it does not start a real comment.






^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-06-28  0:38 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09  6:49 bug#10772: 24.0.93; [patch] Convert tcl-auto-fill-mode to use define-minor-mode William Stevenson
2012-02-09 15:18 ` Juanma Barranquero
2012-02-09 22:09 ` Stefan Monnier
2012-02-11 15:27   ` William Stevenson
2012-02-12  5:12     ` Stefan Monnier
2014-02-25 13:30       ` Xue Fuqiao
2014-02-25 14:30         ` Stefan Monnier
2014-02-25 22:25           ` Xue Fuqiao
2014-02-26 15:40             ` Stefan Monnier
2014-02-26 22:40               ` Xue Fuqiao
2014-02-27  2:55                 ` Stefan Monnier
2014-02-27 17:00                 ` Glenn Morris
2014-02-27 22:33                   ` Xue Fuqiao
2016-02-24  6:42                     ` Lars Ingebrigtsen
2017-06-03  3:45                 ` npostavs
2017-06-28  0:38                   ` npostavs

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.