From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X. Date: Thu, 26 Feb 2015 09:56:45 -0500 Message-ID: References: <20150225191654.16399.81439@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424962704 1111 80.91.229.3 (26 Feb 2015 14:58:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Feb 2015 14:58:24 +0000 (UTC) Cc: "Jan D." To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 26 15:58:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQztD-0003Vi-DV for ged-emacs-devel@m.gmane.org; Thu, 26 Feb 2015 15:58:11 +0100 Original-Received: from localhost ([::1]:59474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQztC-0001ct-TX for ged-emacs-devel@m.gmane.org; Thu, 26 Feb 2015 09:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQzru-0008Bg-AR for emacs-devel@gnu.org; Thu, 26 Feb 2015 09:56:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQzrr-00016W-31 for emacs-devel@gnu.org; Thu, 26 Feb 2015 09:56:50 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQzrr-00016F-0b for emacs-devel@gnu.org; Thu, 26 Feb 2015 09:56:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlkJAPOG1lRsoXmY/2dsb2JhbABbgwaDX8NvgkkEAgKBDUQBAQEBAQF8hA0BBVYjEAs0EhQYDYhkziMBAQEBAQUBAQEBHo94BxaEFAWKJ59LgUUigjKBWiCCcwEBAQ X-IPAS-Result: AlkJAPOG1lRsoXmY/2dsb2JhbABbgwaDX8NvgkkEAgKBDUQBAQEBAQF8hA0BBVYjEAs0EhQYDYhkziMBAQEBAQUBAQEBHo94BxaEFAWKJ59LgUUigjKBWiCCcwEBAQ X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="111539615" Original-Received: from 108-161-121-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.121.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Feb 2015 09:56:45 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 78B451219; Thu, 26 Feb 2015 09:56:45 -0500 (EST) In-Reply-To: (Jan D.'s message of "Wed, 25 Feb 2015 19:16:54 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183514 Archived-At: Hi Jan, > --- a/src/xmenu.c > +++ b/src/xmenu.c > @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f, > widget_value *first_wv, You missed the second definition of create_and_show_popup_menu in xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X. [ Thinking out loud: We really should try and reduce code-duplication in those files. ] Stefan