all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X.
       [not found] ` <E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org>
@ 2015-02-26 14:56   ` Stefan Monnier
  2015-02-26 15:02     ` Jan D.
  2015-02-26 15:12     ` Damien Wyart
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-02-26 14:56 UTC (permalink / raw)
  To: emacs-devel; +Cc: Jan D.

Hi Jan,

> --- a/src/xmenu.c
> +++ b/src/xmenu.c
> @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f,
> widget_value *first_wv,

You missed the second definition of create_and_show_popup_menu in
xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.

[ Thinking out loud: We really should try and reduce code-duplication in
  those files.  ]


        Stefan



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X.
  2015-02-26 14:56   ` [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X Stefan Monnier
@ 2015-02-26 15:02     ` Jan D.
  2015-02-26 15:12     ` Damien Wyart
  1 sibling, 0 replies; 3+ messages in thread
From: Jan D. @ 2015-02-26 15:02 UTC (permalink / raw)
  To: Stefan Monnier, emacs-devel

Stefan Monnier skrev den 2015-02-26 15:56:
> Hi Jan,
>
>> --- a/src/xmenu.c
>> +++ b/src/xmenu.c
>> @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f,
>> widget_value *first_wv,
>
> You missed the second definition of create_and_show_popup_menu in
> xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.
>

Sloppy of me, I'm on it.

> [ Thinking out loud: We really should try and reduce code-duplication in
>    those files.  ]
>

Agreed

	Jan D.





^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X.
  2015-02-26 14:56   ` [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X Stefan Monnier
  2015-02-26 15:02     ` Jan D.
@ 2015-02-26 15:12     ` Damien Wyart
  1 sibling, 0 replies; 3+ messages in thread
From: Damien Wyart @ 2015-02-26 15:12 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Jan D., emacs-devel

* Stefan Monnier <monnier@iro.umontreal.ca> [2015-02-26 09:56]:
> You missed the second definition of create_and_show_popup_menu in
> xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.

There is also a leftover of OUTER_TO_INNER_DIFF in x_menu_show.

-- 
Damien



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 15:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20150225191654.16399.81439@vcs.savannah.gnu.org>
     [not found] ` <E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org>
2015-02-26 14:56   ` [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X Stefan Monnier
2015-02-26 15:02     ` Jan D.
2015-02-26 15:12     ` Damien Wyart

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.