all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "Jan D." <jan.h.d@swipnet.se>
Subject: Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X.
Date: Thu, 26 Feb 2015 09:56:45 -0500	[thread overview]
Message-ID: <jwvbnkgg1to.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org> (Jan D.'s message of "Wed, 25 Feb 2015 19:16:54 +0000")

Hi Jan,

> --- a/src/xmenu.c
> +++ b/src/xmenu.c
> @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f,
> widget_value *first_wv,

You missed the second definition of create_and_show_popup_menu in
xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.

[ Thinking out loud: We really should try and reduce code-duplication in
  those files.  ]


        Stefan



       reply	other threads:[~2015-02-26 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150225191654.16399.81439@vcs.savannah.gnu.org>
     [not found] ` <E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org>
2015-02-26 14:56   ` Stefan Monnier [this message]
2015-02-26 15:02     ` [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X Jan D.
2015-02-26 15:12     ` Damien Wyart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbnkgg1to.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.