From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Smie-auto-fill doesn’t respect comment-auto-fill-only-comments
Date: Sun, 21 May 2017 17:03:57 -0400 [thread overview]
Message-ID: <jwvbmqmdixg.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87r2zidut2.fsf@bapiya
> +(defun internal-auto-fill ()
> + "The function called by `self-insert-command' to perform auto-filling."
> + (when (or (not comment-auto-fill-only-comments)
> + (nth 4 (syntax-ppss)))
> + (do-auto-fill)))
Please check also comment-start, since you don't want to check
(syntax-ppss) if there's no comment-start defined. Well, technically,
it shouldn't make any difference, but it's the way it's been defined so
far, so it makes sense to preserve it.
The patch looks good, but please also remove the
comment-auto-fill-only-comments handling from newcomment.el [ BTW, yes, not
only I feel silly about this name now, but I already felt silly about
it when I came up with it. ]
Stefan
next prev parent reply other threads:[~2017-05-21 21:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 12:04 Smie-auto-fill doesn’t respect comment-auto-fill-only-comments Nikolai Weibull
2017-04-23 19:31 ` Nikolai Weibull
2017-04-25 0:18 ` Ian Dunn
2017-04-30 16:52 ` Tom Tromey
2017-04-30 17:08 ` Stefan Monnier
2017-04-30 17:52 ` Stefan Monnier
2017-05-02 18:57 ` Tom Tromey
2017-05-02 19:18 ` Stefan Monnier
2017-05-03 1:14 ` Ian Dunn
2017-05-21 16:43 ` Tom Tromey
2017-05-21 21:03 ` Stefan Monnier [this message]
2017-05-22 6:24 ` Tom Tromey
2017-05-22 19:12 ` Stefan Monnier
2017-05-29 21:20 ` Tom Tromey
2017-05-30 3:25 ` Stefan Monnier
2017-08-05 20:39 ` Tom Tromey
2017-08-05 20:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvbmqmdixg.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.