From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#27016: possible bug in `defsetf' Date: Sat, 15 Jul 2017 21:03:26 -0400 Message-ID: References: <87h9075j12.fsf@users.sourceforge.net> <87injak1lj.fsf@users.sourceforge.net> <877ezp4v96.fsf@drachen> <871sppgyhb.fsf@users.sourceforge.net> <8760eyfp7s.fsf@users.sourceforge.net> <87a849djvp.fsf@users.sourceforge.net> <874lufets0.fsf@users.sourceforge.net> <87y3rpda89.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500167058 12433 195.159.176.226 (16 Jul 2017 01:04:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Jul 2017 01:04:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Michael Heerdegen , 27016@debbugs.gnu.org, Rafael D Sorkin To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 16 03:04:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWXyg-0002cL-67 for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jul 2017 03:04:06 +0200 Original-Received: from localhost ([::1]:43710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWXyl-0003GH-Pg for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jul 2017 21:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWXyf-0003G0-Sp for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 21:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWXyc-0002xX-Ka for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 21:04:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38219) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWXyc-0002wb-HM for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 21:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dWXyc-0008Fg-39 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 21:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2017 01:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27016 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27016-submit@debbugs.gnu.org id=B27016.150016700931624 (code B ref 27016); Sun, 16 Jul 2017 01:04:02 +0000 Original-Received: (at 27016) by debbugs.gnu.org; 16 Jul 2017 01:03:29 +0000 Original-Received: from localhost ([127.0.0.1]:40896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWXy5-0008E0-C2 for submit@debbugs.gnu.org; Sat, 15 Jul 2017 21:03:29 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWXy4-0008Dt-EH for 27016@debbugs.gnu.org; Sat, 15 Jul 2017 21:03:28 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v6G13Qhm009289; Sat, 15 Jul 2017 21:03:27 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 970C4661DE; Sat, 15 Jul 2017 21:03:26 -0400 (EDT) In-Reply-To: <87y3rpda89.fsf@users.sourceforge.net> (npostavs's message of "Sat, 15 Jul 2017 10:51:34 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6072=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6072> : inlines <5978> : streams <1754363> : uri <2463665> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134608 Archived-At: >> + (push (cons name (eval fun t)) > What does this do? Should it be `lexical-binding' instead of `t'? Sorry, part of an unrelated experiment. >> + (push (cons fun `(,prop ,val >> + . ,(assq fun byte-compile-plist-environment))) > That should be alist-get instead of assq. Good catch. > + (let* ((fun (eval fun t)) > + (prop (eval prop t)) These should likely be just (eval fun) without the `t` either. Tho it doesn't really matter in any case: all those `eval`s just strip off the quote in front of a sexp and should do the same regardless of lexical-binding. Stefan