From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Slightly extending commit 16b0520a9 Date: Sun, 06 Aug 2017 00:08:25 -0400 Message-ID: References: <87o9rtuz2r.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501992655 20970 195.159.176.226 (6 Aug 2017 04:10:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2017 04:10:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 06 06:10:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCtv-0005CF-T2 for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2017 06:10:51 +0200 Original-Received: from localhost ([::1]:59663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCu2-0005w3-1R for ged-emacs-devel@m.gmane.org; Sun, 06 Aug 2017 00:10:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deCtS-0005vp-Dl for emacs-devel@gnu.org; Sun, 06 Aug 2017 00:10:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deCtP-0003Tr-9G for emacs-devel@gnu.org; Sun, 06 Aug 2017 00:10:22 -0400 Original-Received: from [195.159.176.226] (port=52689 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deCtP-0003RK-2H for emacs-devel@gnu.org; Sun, 06 Aug 2017 00:10:19 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1deCtB-0002mm-8c for emacs-devel@gnu.org; Sun, 06 Aug 2017 06:10:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:aO4OhkOeO5OxvQxMvM1KPuBe2YQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217337 Archived-At: > cond = eval_sub (XCAR (args)); > > if (!NILP (cond)) > - return eval_sub (Fcar (XCDR (args))); > + return eval_sub (XCAR (XCDR (args))); I don't see anything in the preceding code that guarantees that `XCDR (args)` holds a cons, so I think XCAR here is unsafe. > @@ -806,7 +806,7 @@ usage: (defconst SYMBOL INITVALUE [DOCSTRING]) */) > if (CONSP (Fcdr (XCDR (XCDR (args))))) > error ("Too many arguments"); > > - tem = eval_sub (Fcar (XCDR (args))); > + tem = eval_sub (XCAR (XCDR (args))); This one looks right, yes, Stefan